Skip to content

fix: incorrect NotificationFromServer method name mapping#111

Merged
hashemix merged 2 commits into
mainfrom
fix/issue-110-incorrect-method-name-mapping
May 18, 2026
Merged

fix: incorrect NotificationFromServer method name mapping#111
hashemix merged 2 commits into
mainfrom
fix/issue-110-incorrect-method-name-mapping

Conversation

@hashemix
Copy link
Copy Markdown
Member

📌 Summary

Fixed incorrect method name mappings in NotificationFromServer::method() that caused all notification types (except CancelledNotification) to incorrectly return CancelledNotification's method value.

🔍 Related Issues

✨ Changes Made

  • Corrected NotificationFromServer::method() in both draft/schema_utils.rs and 2025_11_25/schema_utils.rs

🛠️ Testing Steps

Run the existing test suite to verify the fix doesn't break any functionality.

./scripts/run_test.sh                                                                                                  │
./scripts/run_clippy.sh 

💡 Additional Notes

Cargo.lock was also updated as part of cargo update or similar dependency refresh.

@hashemix hashemix changed the title fix: incorrect NotificationFromServer method name mapping fix: incorrect NotificationFromServer method name mapping May 18, 2026
@hashemix hashemix merged commit 98054fe into main May 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant