feat: introduce framework-agnostic McpHttpError for HTTP layer decoupling#143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
Introduces
McpHttpErrorandMcpHttpResult, a framework-agnostic errorabstraction living in
mcp_http/. This is step 1 of a larger effort todecouple Axum from the core SDK crate .
✨ Changes Made
New
McpHttpErrorenum with 5 variants mirroring the transport-agnostic subsetof
TransportServerError:SessionIdMissing,SessionIdInvalid,StreamIoError,HttpError,TransportErrorMcpHttpResult<T>type aliasimplemented
From<McpHttpError> for TransportServerErrorimplemented
From<TransportServerError> for McpHttpError, common variants mapdirectly; framework-specific variants (ServerStartError, SslCertError,
etc.) map to
HttpError(lossy but covers the common path)new tests covering conversion paths