Prepare release linfa-nn 0.7.2 (#395)

relf · web-flow · commit 77457b22d0b3 · 2025-07-09T09:17:01.000+02:00
* Bump linfa-nn version to 0.7.2

* Linting clippy::uninlined_format_args

* Disable bench as dataset link is broken
diff --git a/algorithms/linfa-bayes/examples/winequality_bayes.rs b/algorithms/linfa-bayes/examples/winequality_bayes.rs
@@ -22,7 +22,7 @@ fn main() -> Result<()> {
     // good       | 7          | 10
     //
     // accuracy 0.8805031, MCC 0.45080978
-    println!("{:?}", cm);
+    println!("{cm:?}");
     println!("accuracy {}, MCC {}", cm.accuracy(), cm.mcc());
 
     Ok(())
diff --git a/algorithms/linfa-bayes/examples/winequality_bernouilli.rs b/algorithms/linfa-bayes/examples/winequality_bernouilli.rs
@@ -21,7 +21,7 @@ fn main() -> Result<()> {
     // good       | 17         | 0
 
     // accuracy 0.8930818, MCC
-    println!("{:?}", cm);
+    println!("{cm:?}");
     println!("accuracy {}, MCC {}", cm.accuracy(), cm.mcc());
 
     Ok(())
diff --git a/algorithms/linfa-bayes/examples/winequality_multinomial.rs b/algorithms/linfa-bayes/examples/winequality_multinomial.rs
@@ -21,7 +21,7 @@ fn main() -> Result<()> {
     // good       | 10         | 7
 
     // accuracy 0.5974843, MCC 0.02000631
-    println!("{:?}", cm);
+    println!("{cm:?}");
     println!("accuracy {}, MCC {}", cm.accuracy(), cm.mcc());
 
     Ok(())
diff --git a/algorithms/linfa-clustering/Cargo.toml b/algorithms/linfa-clustering/Cargo.toml
@@ -46,7 +46,7 @@ space = "0.12"
 thiserror = "1.0"
 #partitions = "0.2.4" This one will break in a future version of Rust and has no replacement
 linfa = { version = "0.7.1", path = "../.." }
-linfa-nn = { version = "0.7.1", path = "../linfa-nn" }
+linfa-nn = { version = "0.7.2", path = "../linfa-nn" }
 noisy_float = "0.2.0"
 
 [dev-dependencies]
diff --git a/algorithms/linfa-clustering/benches/k_means.rs b/algorithms/linfa-clustering/benches/k_means.rs
@@ -50,7 +50,7 @@ fn k_means_bench(c: &mut Criterion) {
         let mut stats = Stats::default();
 
         benchmark.bench_function(
-            BenchmarkId::new("naive_k_means", format!("{}x{}", n_clusters, cluster_size)),
+            BenchmarkId::new("naive_k_means", format!("{n_clusters}x{cluster_size}")),
             |bencher| {
                 bencher.iter(|| {
                     let m = KMeans::params_with_rng(black_box(n_clusters), black_box(rng.clone()))
@@ -88,7 +88,7 @@ fn k_means_incr_bench(c: &mut Criterion) {
         benchmark.bench_function(
             BenchmarkId::new(
                 "incremental_k_means",
-                format!("{}x{}", n_clusters, cluster_size),
+                format!("{n_clusters}x{cluster_size}"),
             ),
             |bencher| {
                 bencher.iter(|| {
@@ -140,7 +140,7 @@ fn k_means_init_bench(c: &mut Criterion) {
             benchmark.bench_function(
                 BenchmarkId::new(
                     "k_means_init",
-                    format!("{:?}:{}x{}", init, n_clusters, cluster_size),
+                    format!("{init:?}:{n_clusters}x{cluster_size}"),
                 ),
                 |bencher| {
                     bencher.iter(|| {
diff --git a/algorithms/linfa-clustering/examples/dbscan.rs b/algorithms/linfa-clustering/examples/dbscan.rs
@@ -41,15 +41,15 @@ fn main() {
     println!("Result: ");
     for (label, count) in label_count {
         match label {
-            None => println!(" - {} noise points", count),
-            Some(i) => println!(" - {} points in cluster {}", count, i),
+            None => println!(" - {count} noise points"),
+            Some(i) => println!(" - {count} points in cluster {i}"),
         }
     }
     println!();
 
     let silhouette_score = cluster_memberships.silhouette_score().unwrap();
 
-    println!("Silhouette score: {}", silhouette_score);
+    println!("Silhouette score: {silhouette_score}");
 
     let (records, cluster_memberships) = (cluster_memberships.records, cluster_memberships.targets);
 
diff --git a/algorithms/linfa-clustering/examples/optics.rs b/algorithms/linfa-clustering/examples/optics.rs
@@ -35,7 +35,7 @@ fn main() {
     println!();
     println!("Result: ");
     for sample in analysis.iter() {
-        println!("{:?}", sample);
+        println!("{sample:?}");
     }
     println!();
 
diff --git a/algorithms/linfa-elasticnet/examples/elasticnet_cv.rs b/algorithms/linfa-elasticnet/examples/elasticnet_cv.rs
@@ -19,7 +19,7 @@ fn main() -> Result<()> {
         dataset.cross_validate_single(5, &models, |prediction, truth| prediction.r2(&truth))?;
 
     for (ratio, r2) in ratios.iter().zip(r2_values.iter()) {
-        println!("L1 ratio: {}, r2 score: {}", ratio, r2);
+        println!("L1 ratio: {ratio}, r2 score: {r2}");
     }
 
     Ok(())
diff --git a/algorithms/linfa-ensemble/examples/bagging_iris.rs b/algorithms/linfa-ensemble/examples/bagging_iris.rs
@@ -25,11 +25,11 @@ fn main() {
 
     // Return highest ranking predictions
     let final_predictions_ensemble = model.predict(&test);
-    println!("Final Predictions: \n{:?}", final_predictions_ensemble);
+    println!("Final Predictions: \n{final_predictions_ensemble:?}");
 
     let cm = final_predictions_ensemble.confusion_matrix(&test).unwrap();
 
-    println!("{:?}", cm);
-    println!("Test accuracy: {} \n with default Decision Tree params, \n Ensemble Size: {},\n Bootstrap Proportion: {}",
-    100.0 * cm.accuracy(), ensemble_size, bootstrap_proportion);
+    println!("{cm:?}");
+    println!("Test accuracy: {} \n with default Decision Tree params, \n Ensemble Size: {ensemble_size},\n Bootstrap Proportion: {bootstrap_proportion}",
+    100.0 * cm.accuracy());
 }
diff --git a/algorithms/linfa-ftrl/benches/ftrl.rs b/algorithms/linfa-ftrl/benches/ftrl.rs
@@ -21,7 +21,7 @@ fn fit_without_prior_model(c: &mut Criterion) {
     for (nfeatures, nrows) in sizes.iter() {
         let dataset = get_dataset(&mut rng, *nrows, *nfeatures);
         group.bench_function(
-            BenchmarkId::new("training on ", format!("dataset {}x{}", nfeatures, nrows)),
+            BenchmarkId::new("training on ", format!("dataset {nfeatures}x{nrows}")),
             |bencher| {
                 bencher.iter(|| {
                     params.fit_with(None, black_box(&dataset)).unwrap();
@@ -46,7 +46,7 @@ fn fit_with_prior_model(c: &mut Criterion) {
         let model = Ftrl::new(valid_params.clone(), *nfeatures);
         let dataset = get_dataset(&mut rng, *nrows, *nfeatures);
         group.bench_function(
-            BenchmarkId::new("training on ", format!("dataset {}x{}", nfeatures, nrows)),
+            BenchmarkId::new("training on ", format!("dataset {nfeatures}x{nrows}")),
             |bencher| {
                 bencher.iter(|| {
                     let _ = params
@@ -72,7 +72,7 @@ fn predict(c: &mut Criterion) {
         let model = Ftrl::new(valid_params.clone(), *nfeatures);
         let dataset = get_dataset(&mut rng, *nrows, *nfeatures);
         group.bench_function(
-            BenchmarkId::new("predicting on ", format!("dataset {}x{}", nfeatures, nrows)),
+            BenchmarkId::new("predicting on ", format!("dataset {nfeatures}x{nrows}")),
             |bencher| {
                 bencher.iter(|| {
                     model.predict(black_box(&dataset));
diff --git a/algorithms/linfa-hierarchical/examples/irisflower.rs b/algorithms/linfa-hierarchical/examples/irisflower.rs
@@ -24,7 +24,7 @@ fn main() -> Result<(), Box<dyn Error>> {
             _ => unreachable!(),
         };
 
-        print!("({} {}) ", id, name);
+        print!("({id} {name}) ");
     }
     println!();
 
diff --git a/algorithms/linfa-ica/src/fast_ica.rs b/algorithms/linfa-ica/src/fast_ica.rs
@@ -50,8 +50,7 @@ impl<F: Float, D: Data<Elem = F>, T> Fit<ArrayBase<D, Ix2>, T, FastIcaError>
         // the number of rows and columns
         if ncomponents > nsamples.min(nfeatures) {
             return Err(FastIcaError::InvalidValue(format!(
-                "ncomponents cannot be greater than the min({}, {}), got {}",
-                nsamples, nfeatures, ncomponents
+                "ncomponents cannot be greater than the min({nsamples}, {nfeatures}), got {ncomponents}"
             )));
         }
 
@@ -252,8 +251,7 @@ impl GFunc {
         //if alpha < 1.0 || alpha > 2.0 {
         if !(1.0..=2.0).contains(&alpha) {
             return Err(FastIcaError::InvalidValue(format!(
-                "alpha must be between 1 and 2 inclusive, got {}",
-                alpha
+                "alpha must be between 1 and 2 inclusive, got {alpha}"
             )));
         }
         let alpha = A::cast(alpha);
diff --git a/algorithms/linfa-kernel/Cargo.toml b/algorithms/linfa-kernel/Cargo.toml
@@ -29,4 +29,4 @@ num-traits = "0.2"
 sprs = { version = "=0.11.1", default-features = false }
 
 linfa = { version = "0.7.1", path = "../.." }
-linfa-nn = { version = "0.7.1", path = "../linfa-nn" }
+linfa-nn = { version = "0.7.2", path = "../linfa-nn" }
diff --git a/algorithms/linfa-linear/benches/ols_bench.rs b/algorithms/linfa-linear/benches/ols_bench.rs
@@ -32,7 +32,7 @@ fn bench(c: &mut Criterion) {
     let glm_id = "GLM-".to_string();
 
     for (size, num_feat) in params {
-        let suffix = format!("{}Feats", num_feat);
+        let suffix = format!("{num_feat}Feats");
         let mut func_name = ols_id.clone();
         func_name.push_str(&suffix);
 
diff --git a/algorithms/linfa-linear/examples/glm.rs b/algorithms/linfa-linear/examples/glm.rs
@@ -28,7 +28,7 @@ fn main() -> Result<(), f64> {
         .mapv(|x| x.abs())
         .mean();
 
-    println!("{:?}", loss);
+    println!("{loss:?}");
 
     Ok(())
 }
diff --git a/algorithms/linfa-logistic/examples/logistic_cv.rs b/algorithms/linfa-logistic/examples/logistic_cv.rs
@@ -27,7 +27,7 @@ fn main() -> Result<()> {
 
     // display the accuracy of the models along with their regularization coefficient
     for (alpha, accuracy) in alphas.iter().zip(accuracies.iter()) {
-        println!("Alpha: {}, accuracy: {} ", alpha, accuracy);
+        println!("Alpha: {alpha}, accuracy: {accuracy} ");
     }
 
     Ok(())
diff --git a/algorithms/linfa-logistic/examples/winequality_logistic.rs b/algorithms/linfa-logistic/examples/winequality_logistic.rs
@@ -29,7 +29,7 @@ fn main() -> Result<(), Box<dyn Error>> {
     // Print the confusion matrix, this will print a table with four entries. On the diagonal are
     // the number of true-positive and true-negative predictions, off the diagonal are
     // false-positive and false-negative
-    println!("{:?}", cm);
+    println!("{cm:?}");
 
     // Calculate the accuracy and Matthew Correlation Coefficient (cross-correlation between
     // predicted and targets)
diff --git a/algorithms/linfa-logistic/examples/winequality_multi_logistic.rs b/algorithms/linfa-logistic/examples/winequality_multi_logistic.rs
@@ -26,7 +26,7 @@ fn main() -> Result<(), Box<dyn Error>> {
     // Print the confusion matrix, this will print a table with four entries. On the diagonal are
     // the number of true-positive and true-negative predictions, off the diagonal are
     // false-positive and false-negative
-    println!("{:?}", cm);
+    println!("{cm:?}");
 
     // Calculate the accuracy and Matthew Correlation Coefficient (cross-correlation between
     // predicted and targets)
diff --git a/algorithms/linfa-nn/Cargo.toml b/algorithms/linfa-nn/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "linfa-nn"
-version = "0.7.1"
+version = "0.7.2"
 authors = ["YuhanLiin <yuhanliin+github@protonmail.com>"]
 edition = "2018"
 description = "A collection of nearest neighbour algorithms"
diff --git a/algorithms/linfa-nn/benches/nn.rs b/algorithms/linfa-nn/benches/nn.rs
@@ -23,7 +23,7 @@ fn nn_build_bench(c: &mut Criterion) {
 
         for (alg, name) in algorithms {
             benchmark.bench_with_input(
-                BenchmarkId::new(*name, format!("{}", n_points)),
+                BenchmarkId::new(*name, format!("{n_points}")),
                 &points_arr,
                 |bencher, points_arr| {
                     let points = points_arr.view();
@@ -56,7 +56,7 @@ fn k_nearest_bench(c: &mut Criterion) {
         for (alg, name) in algorithms {
             let nn = alg.from_batch(&points, L2Dist).unwrap();
             benchmark.bench_with_input(
-                BenchmarkId::new(*name, format!("{}-{}", n_points, k)),
+                BenchmarkId::new(*name, format!("{n_points}-{k}")),
                 &k,
                 |bencher, &k| {
                     bencher.iter(|| {
@@ -91,7 +91,7 @@ fn within_range_bench(c: &mut Criterion) {
         for (alg, name) in algorithms {
             let nn = alg.from_batch(&points, L2Dist).unwrap();
             benchmark.bench_with_input(
-                BenchmarkId::new(*name, format!("{}-{}", n_points, range)),
+                BenchmarkId::new(*name, format!("{n_points}-{range}")),
                 &range,
                 |bencher, &range| {
                     bencher.iter(|| {
diff --git a/algorithms/linfa-pls/benches/pls.rs b/algorithms/linfa-pls/benches/pls.rs
@@ -50,7 +50,7 @@ fn bench(c: &mut Criterion) {
         pls_cca_id.push_str(name);
 
         for (size, num_feat) in params {
-            let suffix = format!("{}Feats", num_feat);
+            let suffix = format!("{num_feat}Feats");
             let mut func_name = pls_regression_id.clone();
             func_name.push_str(&suffix);
             let dataset = make_dataset(size, num_feat, 1, feat_distr, target_distr);
diff --git a/algorithms/linfa-pls/examples/pls_regression.rs b/algorithms/linfa-pls/examples/pls_regression.rs
@@ -31,7 +31,7 @@ fn main() -> Result<()> {
         .fit(&ds)?;
 
     println!("True B (such that: Y = XB + noise)");
-    println!("{:?}", b);
+    println!("{b:?}");
 
     // PLS regression coefficients is an estimation of B
     println!("Estimated B");
diff --git a/algorithms/linfa-preprocessing/Cargo.toml b/algorithms/linfa-preprocessing/Cargo.toml
@@ -45,7 +45,7 @@ features = ["std", "derive"]
 linfa-datasets = { version = "0.7.1", path = "../../datasets", features = [
     "diabetes",
     "winequality",
-    "generate"
+    "generate",
 ] }
 linfa-bayes = { version = "0.7.1", path = "../linfa-bayes" }
 iai = "0.1"
@@ -56,9 +56,10 @@ linfa = { version = "0.7.1", path = "../..", features = ["benchmarks"] }
 criterion = "0.4.0"
 statrs = "0.16.0"
 
-[[bench]]
-name = "vectorizer_bench"
-harness = false
+# FIXME: Disabled as dataset link is broken
+# [[bench]]
+# name = "vectorizer_bench"
+# harness = false
 
 [[bench]]
 name = "linear_scaler_bench"
diff --git a/algorithms/linfa-preprocessing/benches/linear_scaler_bench.rs b/algorithms/linfa-preprocessing/benches/linear_scaler_bench.rs
@@ -20,7 +20,7 @@ fn bench(c: &mut Criterion) {
         for nfeatures in (10..100).step_by(10) {
             let dataset = make_dataset(size, nfeatures, 1, feat_distr, target_distr);
             benchmark.bench_function(
-                BenchmarkId::new(fn_name, format!("{}x{}", nfeatures, size)),
+                BenchmarkId::new(fn_name, format!("{nfeatures}x{size}")),
                 |bencher| {
                     bencher.iter(|| {
                         liner_scaler
diff --git a/algorithms/linfa-preprocessing/benches/norm_scaler_bench.rs b/algorithms/linfa-preprocessing/benches/norm_scaler_bench.rs
@@ -20,7 +20,7 @@ fn bench(c: &mut Criterion) {
         for nfeatures in (10..100).step_by(10) {
             let dataset = make_dataset(size, nfeatures, 1, feat_distr, target_distr);
             benchmark.bench_function(
-                BenchmarkId::new(fn_name, format!("{}x{}", nfeatures, size)),
+                BenchmarkId::new(fn_name, format!("{nfeatures}x{size}")),
                 |bencher| {
                     bencher.iter(|| {
                         scaler.transform(black_box(dataset.view()));
diff --git a/algorithms/linfa-preprocessing/benches/whitening_bench.rs b/algorithms/linfa-preprocessing/benches/whitening_bench.rs
@@ -21,7 +21,7 @@ fn bench(c: &mut Criterion) {
         for nfeatures in (10..100).step_by(10) {
             let dataset = make_dataset(size, nfeatures, 1, feat_distr, target_distr);
             benchmark.bench_function(
-                BenchmarkId::new(fn_name, format!("{}x{}", nfeatures, size)),
+                BenchmarkId::new(fn_name, format!("{nfeatures}x{size}")),
                 |bencher| {
                     bencher.iter(|| {
                         whitener
diff --git a/algorithms/linfa-preprocessing/examples/count_vectorization.rs b/algorithms/linfa-preprocessing/examples/count_vectorization.rs
@@ -150,7 +150,7 @@ fn main() {
         .unwrap();
     // 0.9944
     let accuracy = cm.f1_score();
-    println!("The fitted model has a training f1 score of {}", accuracy);
+    println!("The fitted model has a training f1 score of {accuracy}");
 
     // --- Test set
 
@@ -174,7 +174,7 @@ fn main() {
     let cm = test_prediction.confusion_matrix(&test_dataset).unwrap();
     // 0.9523
     let accuracy = cm.f1_score();
-    println!("The model has a test f1 score of {}", accuracy);
+    println!("The model has a test f1 score of {accuracy}");
 
     delete_20news_bydate();
 }
diff --git a/algorithms/linfa-preprocessing/examples/scaling.rs b/algorithms/linfa-preprocessing/examples/scaling.rs
@@ -27,9 +27,6 @@ fn main() {
         .accuracy();
     let cm = model.predict(&valid).confusion_matrix(&valid).unwrap();
     let valid_acc = cm.accuracy();
-    println!(
-        "Scaled model training and validation accuracies: {} - {}",
-        train_acc, valid_acc
-    );
-    println!("{:?}", cm);
+    println!("Scaled model training and validation accuracies: {train_acc} - {valid_acc}");
+    println!("{cm:?}",);
 }
diff --git a/algorithms/linfa-preprocessing/examples/tfidf_vectorization.rs b/algorithms/linfa-preprocessing/examples/tfidf_vectorization.rs
@@ -148,7 +148,7 @@ fn main() {
         .unwrap();
     // 0.9994
     let accuracy = cm.f1_score();
-    println!("The fitted model has a training f1 score of {}", accuracy);
+    println!("The fitted model has a training f1 score of {accuracy}",);
 
     // --- Test set
 
@@ -157,9 +157,8 @@ fn main() {
     let (test_filenames, test_targets, ntargets) = load_test_set(&desired_targets).unwrap();
 
     println!(
-        "The test set is comprised of {} documents with {} different targets",
+        "The test set is comprised of {} documents with {ntargets} different targets",
         test_filenames.len(),
-        ntargets
     );
     let test_records = vectorizer
         .transform_files(&test_filenames, ISO_8859_1, Strict)
@@ -171,7 +170,7 @@ fn main() {
     let cm = test_prediction.confusion_matrix(&test_dataset).unwrap();
     // 0.8402
     let accuracy = cm.f1_score();
-    println!("The model has a test f1 score of {}", accuracy);
+    println!("The model has a test f1 score of {accuracy}");
 
     delete_20news_bydate();
 }
diff --git a/algorithms/linfa-preprocessing/examples/whitening.rs b/algorithms/linfa-preprocessing/examples/whitening.rs
@@ -27,9 +27,6 @@ fn main() {
         .accuracy();
     let cm = model.predict(&valid).confusion_matrix(&valid).unwrap();
     let valid_acc = cm.accuracy();
-    println!(
-        "Whitened model training and validation accuracies: {} - {}",
-        train_acc, valid_acc
-    );
-    println!("{:?}", cm);
+    println!("Whitened model training and validation accuracies: {train_acc} - {valid_acc}");
+    println!("{cm:?}",);
 }
diff --git a/algorithms/linfa-preprocessing/src/countgrams/mod.rs b/algorithms/linfa-preprocessing/src/countgrams/mod.rs
diff --git a/algorithms/linfa-preprocessing/src/linear_scaling.rs b/algorithms/linfa-preprocessing/src/linear_scaling.rs
diff --git a/algorithms/linfa-svm/examples/noisy_sin_svr.rs b/algorithms/linfa-svm/examples/noisy_sin_svr.rs
diff --git a/algorithms/linfa-svm/examples/winequality_multi_svm.rs b/algorithms/linfa-svm/examples/winequality_multi_svm.rs
diff --git a/algorithms/linfa-svm/examples/winequality_svm.rs b/algorithms/linfa-svm/examples/winequality_svm.rs
diff --git a/algorithms/linfa-svm/src/regression.rs b/algorithms/linfa-svm/src/regression.rs
diff --git a/algorithms/linfa-trees/examples/decision_tree.rs b/algorithms/linfa-trees/examples/decision_tree.rs
diff --git a/algorithms/linfa-trees/src/decision_trees/tikz.rs b/algorithms/linfa-trees/src/decision_trees/tikz.rs

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ fn main() {`
`35`	`35`	`println!();`
`36`	`36`	`println!("Result: ");`
`37`	`37`	`for sample in analysis.iter() {`
`38`		`- println!("{:?}", sample);`
	`38`	`+ println!("{sample:?}");`
`39`	`39`	`}`
`40`	`40`	`println!();`
`41`	`41`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ fn main() -> Result<()> {`
`19`	`19`	`dataset.cross_validate_single(5, &models, \|prediction, truth\| prediction.r2(&truth))?;`
`20`	`20`
`21`	`21`	`for (ratio, r2) in ratios.iter().zip(r2_values.iter()) {`
`22`		`- println!("L1 ratio: {}, r2 score: {}", ratio, r2);`
	`22`	`+ println!("L1 ratio: {ratio}, r2 score: {r2}");`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`Ok(())`