Implement rm_newline#163
Merged
Merged
Conversation
hronro
added a commit
to hronro/simple-file-store
that referenced
this pull request
Jun 30, 2025
My PR for the template engine `sailfish` is not merged yet (rust-sailfish/sailfish#163), let's use my fork for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is an option called
rm_whitespacethat removes all leading and trailing whitespaces from each line in the templates. According to the Unicode Derived Core Property, whitespace includes newlines, so I initially expected that enablingrm_whitespacewould also remove newlines. However, I discovered that the current implementation explicitly retains newlines for some reason.To avoid disrupting this existing behavior, which some users may rely on, I have added a new option called
rm_newlinethat removes all newlines from the templates.Please note that
rm_newlinecan also be used whenrm_whitespaceis disabled.