Skip to content

Commit 9ea8c4b

Browse files
palfreypalfrey
authored
Merge pull request #1958 from palfrey/fix-gnu-links
Fix GNU links
2 parents cd372d9 + 170e52f commit 9ea8c4b

File tree

1 file changed

+36
-36
lines changed

1 file changed

+36
-36
lines changed

‎src/main.rs

+36-36
Original file line numberDiff line numberDiff line change
@@ -41,42 +41,44 @@ fn override_stars(level: u32, text: &str) -> Option<u32> {
4141
lazy_static! {
4242
// We don't explicitly check these, because they just bug out in GitHub. We're _hoping_ they don't go away!
4343
static ref ASSUME_WORKS: Vec<String> = vec![
44-
"https://www.reddit.com/r/rust/".to_string(),
45-
"https://opcfoundation.org/about/opc-technologies/opc-ua/".to_string(),
46-
"https://arangodb.com".to_string(),
47-
"https://git.sr.ht/~lessa/pepper".to_string()
48-
];
44+
"https://www.reddit.com/r/rust/",
45+
"https://opcfoundation.org/about/opc-technologies/opc-ua/",
46+
"https://arangodb.com",
47+
"https://git.sr.ht/~lessa/pepper",
48+
"https://www.gnu.org/software/emacs/",
49+
"http://www.gnu.org/software/gsl/"
50+
].iter().map(|s| s.to_string()).collect();
4951
// Overrides for popularity count, each needs a good reason (i.e. downloads/stars we don't support automatic counting of)
5052
// Each is a URL that's "enough" for an item to pass the popularity checks
5153
static ref POPULARITY_OVERRIDES: Vec<String> = vec![
52-
"https://github.com/maidsafe".to_string(), // Many repos of Rust code, collectively > 50 stars
53-
"https://pijul.org".to_string(), // Uses it's own VCS at https://nest.pijul.com/pijul/pijul with 190 stars at last check
54-
"https://gitlab.com/veloren/veloren".to_string(), // No direct gitlab support, but >1000 stars there
55-
"https://gitlab.redox-os.org/redox-os/redox".to_string(), // 394 stars
56-
"https://amp.rs".to_string(), // https://github.com/jmacdonald/amp has 2.9k stars
57-
"https://marketplace.visualstudio.com/items?itemName=vadimcn.vscode-lldb".to_string(), // > 350k downloads
58-
"https://gitpod.io".to_string(), // https://github.com/gitpod-io/gitpod has 4.7k stars
59-
"https://wiki.gnome.org/Apps/Builder".to_string(), // https://gitlab.gnome.org/GNOME/gnome-builder has 133 stars
60-
"https://www.jetbrains.com/rust/".to_string(), // popular closed-source IDE, free for non-commercial use
61-
"https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml".to_string(), // > 1M downloads
62-
"https://marketplace.visualstudio.com/items?itemName=rust-lang.rust-analyzer".to_string(), // > 260k downloads
63-
"https://marketplace.visualstudio.com/items?itemName=rust-lang.rust".to_string(), // > 1M downloads
64-
"https://docs.rs".to_string(), // https://github.com/rust-lang/docs.rs has >600 stars
65-
"https://github.com/rust-bio".to_string(), // https://github.com/rust-bio/rust-bio on it's own has >900 stars
66-
"https://github.com/contain-rs".to_string(), // Lots of repos with good star counts
67-
"https://github.com/georust".to_string(), // Lots of repos with good star counts
68-
"http://kiss3d.org".to_string(), // https://github.com/sebcrozet/kiss3d has >900 stars
69-
"https://github.com/rust-qt".to_string(), // Various high-stars repositories
70-
"https://chromium.googlesource.com/chromiumos/platform/crosvm/".to_string(), // Can't tell count directly, but various mirrors of it (e.g. https://github.com/dgreid/crosvm) have enough stars that it's got enough interest
71-
"https://crates.io".to_string(), // This one gets a free pass :)
72-
"https://cloudsmith.com/product/formats/cargo-registry".to_string(), // First private cargo registry (https://cloudsmith.com/blog/worlds-first-private-cargo-registry-w-cloudsmith-rust/) and not much in the way of other options yet. See also https://github.com/rust-unofficial/awesome-rust/pull/1141#discussion_r688711555
73-
"https://gitlab.com/ttyperacer/terminal-typeracer".to_string(), // GitLab repo with >40 stars.
74-
"https://github.com/esp-rs".to_string(), // Espressif Rust Organization (Organizations have no stars).
75-
"https://github.com/arkworks-rs".to_string(), // Rust ecosystem for zkSNARK programming (Organizations have no stars)
76-
"https://marketplace.visualstudio.com/items?itemName=jinxdash.prettier-rust".to_string(), // https://github.com/jinxdash/prettier-plugin-rust has >50 stars
77-
"https://github.com/andoriyu/uclicious".to_string(), // FIXME: CI hack. the crate has a higher count, but we don't refresh.
78-
"https://marketplace.visualstudio.com/items?itemName=fill-labs.dependi".to_string(), // marketplace link , but also has enough stars
79-
];
54+
"https://github.com/maidsafe", // Many repos of Rust code, collectively > 50 stars
55+
"https://pijul.org", // Uses it's own VCS at https://nest.pijul.com/pijul/pijul with 190 stars at last check
56+
"https://gitlab.com/veloren/veloren", // No direct gitlab support, but >1000 stars there
57+
"https://gitlab.redox-os.org/redox-os/redox", // 394 stars
58+
"https://amp.rs", // https://github.com/jmacdonald/amp has 2.9k stars
59+
"https://marketplace.visualstudio.com/items?itemName=vadimcn.vscode-lldb", // > 350k downloads
60+
"https://gitpod.io", // https://github.com/gitpod-io/gitpod has 4.7k stars
61+
"https://wiki.gnome.org/Apps/Builder", // https://gitlab.gnome.org/GNOME/gnome-builder has 133 stars
62+
"https://www.jetbrains.com/rust/", // popular closed-source IDE, free for non-commercial use
63+
"https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml", // > 1M downloads
64+
"https://marketplace.visualstudio.com/items?itemName=rust-lang.rust-analyzer", // > 260k downloads
65+
"https://marketplace.visualstudio.com/items?itemName=rust-lang.rust", // > 1M downloads
66+
"https://docs.rs", // https://github.com/rust-lang/docs.rs has >600 stars
67+
"https://github.com/rust-bio", // https://github.com/rust-bio/rust-bio on it's own has >900 stars
68+
"https://github.com/contain-rs", // Lots of repos with good star counts
69+
"https://github.com/georust", // Lots of repos with good star counts
70+
"http://kiss3d.org", // https://github.com/sebcrozet/kiss3d has >900 stars
71+
"https://github.com/rust-qt", // Various high-stars repositories
72+
"https://chromium.googlesource.com/chromiumos/platform/crosvm/", // Can't tell count directly, but various mirrors of it (e.g. https://github.com/dgreid/crosvm) have enough stars that it's got enough interest
73+
"https://crates.io", // This one gets a free pass :)
74+
"https://cloudsmith.com/product/formats/cargo-registry", // First private cargo registry (https://cloudsmith.com/blog/worlds-first-private-cargo-registry-w-cloudsmith-rust/) and not much in the way of other options yet. See also https://github.com/rust-unofficial/awesome-rust/pull/1141#discussion_r688711555
75+
"https://gitlab.com/ttyperacer/terminal-typeracer", // GitLab repo with >40 stars.
76+
"https://github.com/esp-rs", // Espressif Rust Organization (Organizations have no stars).
77+
"https://github.com/arkworks-rs", // Rust ecosystem for zkSNARK programming (Organizations have no stars)
78+
"https://marketplace.visualstudio.com/items?itemName=jinxdash.prettier-rust", // https://github.com/jinxdash/prettier-plugin-rust has >50 stars
79+
"https://github.com/andoriyu/uclicious", // FIXME: CI hack. the crate has a higher count, but we don't refresh.
80+
"https://marketplace.visualstudio.com/items?itemName=fill-labs.dependi", // marketplace link , but also has enough stars
81+
].iter().map(|s| s.to_string()).collect();
8082
}
8183

8284
#[derive(Debug, Error, Serialize, Deserialize)]
@@ -486,9 +488,7 @@ async fn main() -> Result<()> {
486488
} else {
487489
github_stars = get_stars(&github_url).await;
488490
if let Some(raw_stars) = github_stars {
489-
popularity_data
490-
.github_stars
491-
.insert(github_url.to_string(), raw_stars);
491+
popularity_data.github_stars.insert(github_url, raw_stars);
492492
if raw_stars >= required_stars {
493493
fs::write(
494494
"results/popularity.yaml",

0 commit comments

Comments
 (0)