Commit cea4e45
committed
tests: add x509-limbo coverage
This adds x509-limbo coverage using a vendored copy of the limbo.json
test data (bzipped to reduce the size from 39mb to 7.3mb). We take a git
dev dep on the upstream x509-limbo repo to reuse its harness helpers. By
doing this we can catch regressions proactively as part of the
development cycle instead of reactively when the upstream x509-limbo
project updates published webpki releases.
The test rigging is similar to the upstream "rustls-webpki" harness,
except that it tests against the expected outcomes per-testcase mod an
exceptions JSON file. That exceptions file is pre-populated based on the
current divergences listed on the x509-limbo.com website[0]. Some of
these divergences may motivate changes in the verifier that will remove
the exception, while others (e.g. not honoring EE cert CNs) will always
remain due to explicit design choices of this crate.
The test is ignored by default, because the runtime is longer than the
other tests.
With this in place we can also remove the ignored by default bettertls
coverage, since that project is included as a subset[1] of the x509-limbo
test cases.
[0]: https://x509-limbo.com/anomalous-results/rustls-webpki/
[1]: https://x509-limbo.com/testcases/bettertls/1 parent c36ee95 commit cea4e45
File tree
10 files changed
+924
-361
lines changed- tests
- third-party
- bettertls
- x509-limbo
10 files changed
+924
-361
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
86 | 88 | | |
87 | 89 | | |
88 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
30 | 32 | | |
| 33 | + | |
| 34 | + | |
This file was deleted.
0 commit comments