Skip to content

Commit 918b032

Browse files
ruvnetruvnet
andcommitted
fix(gnn): remove broken linux-arm64-musl target from build matrix
The linux-arm64-musl target in build-gnn.yml used aarch64-linux-gnu-gcc as its linker, which is the GNU linker — not a musl cross-compiler. This caused every linux-arm64-musl build to fail silently (musl needs aarch64-linux-musl-gcc). The arm64-gnu builds were unaffected but the failed musl artifact caused confusion. - Remove linux-arm64-musl from the build matrix - Remove its install step and wrong linker env var - Remove @ruvector/gnn-linux-arm64-musl from package.json optionalDeps (it was never successfully published; npm warned on every install) - Remove aarch64-unknown-linux-musl from napi triples Closes #110 (partial — arm64-gnu remains; the x64-musl target is kept as it uses the correct musl-tools toolchain). Co-Authored-By: claude-flow <ruv@ruv.net>
1 parent b8faecf commit 918b032

2 files changed

Lines changed: 1 addition & 17 deletions

File tree

.github/workflows/build-gnn.yml

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ jobs:
4040
- host: ubuntu-22.04
4141
target: aarch64-unknown-linux-gnu
4242
platform: linux-arm64-gnu
43-
- host: ubuntu-22.04
44-
target: aarch64-unknown-linux-musl
45-
platform: linux-arm64-musl
4643
- host: macos-14
4744
target: x86_64-apple-darwin
4845
platform: darwin-x64
@@ -87,12 +84,6 @@ jobs:
8784
sudo apt-get update
8885
sudo apt-get install -y musl-tools
8986
90-
- name: Install cross-compilation tools (Linux ARM64 musl)
91-
if: matrix.settings.platform == 'linux-arm64-musl'
92-
run: |
93-
sudo apt-get update
94-
sudo apt-get install -y gcc-aarch64-linux-gnu g++-aarch64-linux-gnu musl-tools
95-
9687
- name: Install NAPI-RS CLI
9788
run: npm install -g @napi-rs/cli
9889

@@ -106,7 +97,6 @@ jobs:
10697
napi build --platform --release --target ${{ matrix.settings.target }} -p ruvector-gnn-node
10798
env:
10899
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: aarch64-linux-gnu-gcc
109-
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_MUSL_LINKER: aarch64-linux-gnu-gcc
110100

111101
- name: Find built .node files (debug)
112102
shell: bash
@@ -161,7 +151,7 @@ jobs:
161151
echo "=== Downloaded artifacts ==="
162152
find artifacts -name "*.node"
163153
164-
for platform in linux-x64-gnu linux-x64-musl linux-arm64-gnu linux-arm64-musl darwin-x64 darwin-arm64 win32-x64-msvc; do
154+
for platform in linux-x64-gnu linux-x64-musl linux-arm64-gnu darwin-x64 darwin-arm64 win32-x64-msvc; do
165155
if [ -d "artifacts/gnn-bindings-${platform}" ]; then
166156
mkdir -p "crates/ruvector-gnn-node/npm/${platform}"
167157
cp -v artifacts/gnn-bindings-${platform}/*.node "crates/ruvector-gnn-node/npm/${platform}/" || true
@@ -256,10 +246,6 @@ jobs:
256246
OS="linux"; CPU="arm64"; LIBC='"libc": ["glibc"],'
257247
NODE_NAME="ruvector-gnn.linux-arm64-gnu.node"
258248
;;
259-
linux-arm64-musl)
260-
OS="linux"; CPU="arm64"; LIBC='"libc": ["musl"],'
261-
NODE_NAME="ruvector-gnn.linux-arm64-musl.node"
262-
;;
263249
darwin-x64)
264250
OS="darwin"; CPU="x64"; LIBC=""
265251
NODE_NAME="ruvector-gnn.darwin-x64.node"

crates/ruvector-gnn-node/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
"x86_64-unknown-linux-gnu",
1313
"x86_64-unknown-linux-musl",
1414
"aarch64-unknown-linux-gnu",
15-
"aarch64-unknown-linux-musl",
1615
"x86_64-apple-darwin",
1716
"aarch64-apple-darwin",
1817
"x86_64-pc-windows-msvc"
@@ -56,7 +55,6 @@
5655
"@ruvector/gnn-linux-x64-gnu": "0.1.25",
5756
"@ruvector/gnn-linux-x64-musl": "0.1.25",
5857
"@ruvector/gnn-linux-arm64-gnu": "0.1.25",
59-
"@ruvector/gnn-linux-arm64-musl": "0.1.25",
6058
"@ruvector/gnn-darwin-x64": "0.1.25",
6159
"@ruvector/gnn-darwin-arm64": "0.1.25",
6260
"@ruvector/gnn-win32-x64-msvc": "0.1.25"

0 commit comments

Comments
 (0)