Skip to content

Rename 'oidc_provider' Header (remove underscore) #161

@fxjordan

Description

@fxjordan

The oidc_provider header contains an underscore. This seems to be allowed in HTTP, but so uncommon that Nginx needs a special configuration flag to allow for headers containing an underscore (https://dev.to/thesameeric/dont-use-underscores-in-your-http-headers-gfp).

In a recent bug, this caused a lot of extra work for me while find out why the OIDC provider was not set correctly. Sometimes, developers may even not know that a Nginx reverse proxy is running in front of their las2peer application and get strange behavior. Also, they might not be able to change the Nginx configuration in some cases.

Therefore, I'm proposing to rename the header to oidc-provider. The old header name can still be parsed for legacy reasons while we introduce the new header name.

public static final String OIDC_PROVIDER_KEY = "oidc_provider";

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions