nix: improve checks

Author: ryanccn

.github/workflows/check.yml

@@ -27,7 +27,7 @@ jobs:
         uses: DeterminateSystems/magic-nix-cache-action@main
 
       - name: Check
-        run: nix build --fallback --print-build-logs '.#check-clippy'
+        run: nix build --fallback --print-build-logs ".#checks.$(nix eval --impure --raw --expr "builtins.currentSystem").clippy"
 
       - name: Upload analysis results
         uses: github/codeql-action/upload-sarif@v3
@@ -49,7 +49,7 @@ jobs:
         uses: DeterminateSystems/magic-nix-cache-action@main
 
       - name: Check
-        run: nix build --fallback --print-build-logs '.#check-rustfmt'
+        run: nix build --fallback --print-build-logs ".#checks.$(nix eval --impure --raw --expr "builtins.currentSystem").rustfmt"
 
   nixfmt:
     runs-on: ubuntu-latest
@@ -65,7 +65,7 @@ jobs:
         uses: DeterminateSystems/magic-nix-cache-action@main
 
       - name: Check
-        run: nix build --fallback --print-build-logs '.#check-nixfmt'
+        run: nix build --fallback --print-build-logs ".#checks.$(nix eval --impure --raw --expr "builtins.currentSystem").nixfmt"
 
   reuse:
     runs-on: ubuntu-latest
@@ -81,4 +81,4 @@ jobs:
         uses: DeterminateSystems/magic-nix-cache-action@main
 
       - name: Check
-        run: nix build --fallback --print-build-logs '.#check-reuse'
+        run: nix build --fallback --print-build-logs ".#checks.$(nix eval --impure --raw --expr "builtins.currentSystem").reuse"

flake.nix

@@ -44,9 +44,10 @@
             pkgs.stdenv.mkDerivation (
               {
                 name = "check-${name}";
-
+                inherit (self.packages.${system}.nyoom) src;
                 inherit nativeBuildInputs;
-                inherit (self.packages.${system}.nyoom) src cargoDeps;
+
+                strictDeps = true;
 
                 buildPhase = ''
                   ${command}
@@ -81,20 +82,29 @@
           clippy = mkFlakeCheck {
             name = "clippy";
 
-            nativeBuildInputs = with pkgs; [
-              rustPlatform.cargoSetupHook
-              cargo
-              rustc
-              clippy
-              clippy-sarif
-              sarif-fmt
-            ];
+            nativeBuildInputs =
+              with pkgs;
+              [
+                rustPlatform.cargoSetupHook
+                cargo
+                rustc
+                clippy
+                clippy-sarif
+                sarif-fmt
+              ]
+              ++ lib.optionals stdenv.hostPlatform.isDarwin [
+                pkg-config
+              ];
 
             command = ''
               cargo clippy --all-features --all-targets --tests \
                 --offline --message-format=json \
                 | clippy-sarif | tee $out | sarif-fmt
             '';
+
+            extraConfig = {
+              inherit (self.packages.${system}.nyoom) cargoDeps buildInputs;
+            };
           };
 
           reuse = mkFlakeCheck {
@@ -153,9 +163,6 @@
           inherit (packages) nyoom;
           default = packages.nyoom;
         }
-        // (lib.attrsets.mapAttrs' (
-          name: value: lib.nameValuePair "check-${name}" value
-        ) self.checks.${system})
       );
 
       legacyPackages = forAllSystems (

nix/package.nix

@@ -39,7 +39,7 @@ rustPlatform.buildRustPackage rec {
     lockFile = ../Cargo.lock;
   };
 
-  buildInputs = lib.optionals stdenv.isDarwin [
+  buildInputs = lib.optionals stdenv.hostPlatform.isDarwin [
     darwin.apple_sdk.frameworks.CoreFoundation
     darwin.apple_sdk.frameworks.Security
     darwin.apple_sdk.frameworks.SystemConfiguration
@@ -51,7 +51,7 @@ rustPlatform.buildRustPackage rec {
     [
       installShellFiles
     ]
-    ++ lib.optionals stdenv.isDarwin [
+    ++ lib.optionals stdenv.hostPlatform.isDarwin [
       pkg-config
     ];