Disallow unsupported options (#112)

Drop support for Python 3.8, due to dropped support for Python 3.8 in a test dependency (dj-database-url).

Author: ryanhiebert

.github/workflows/build.yml

@@ -14,7 +14,6 @@ jobs:
         - "5.1"
         - "5.2"
         python-version:
-        - "3.8"
         - "3.9"
         - "3.10"
         - "3.11"
@@ -28,20 +27,14 @@ jobs:
         exclude:
         - django-version: "4.2"
           python-version: "3.13"
-        - django-version: "5.0"
-          python-version: "3.8"
         - django-version: "5.0"
           python-version: "3.9"
         - django-version: "5.0"
           python-version: "3.13"
-        - django-version: "5.1"
-          python-version: "3.8"
         - django-version: "5.1"
           python-version: "3.9"
         - django-version: "5.1"
           python-version: "3.13"
-        - django-version: "5.2"
-          python-version: "3.8"
         - django-version: "5.2"
           python-version: "3.9"
 

HISTORY.rst

@@ -1,3 +1,11 @@
+6.0 (2025-06-03)
+++++++++++++++++
+
+* Drop support for Python 3.8.
+* Raise errors early for unsupported options,
+  including ``--fake-initial``, ``--plan``, ``--check``,
+  ``--prune``, and ``--run-syncdb``.
+
 5.3 (2025-04-02)
 ++++++++++++++++
 

README.rst

@@ -111,7 +111,7 @@ then add this to the ``repos`` key of your ``.pre-commit-config.yaml``:
 
     repos:
         -   repo: https://github.com/ryanhiebert/django-safemigrate
-            rev: "5.3"
+            rev: "6.0"
             hooks:
             -   id: check
 

pyproject.toml

@@ -4,12 +4,12 @@ build-backend = "hatchling.build"
 
 [project]
 name = "django-safemigrate"
-version = "5.3"
+version = "6.0"
 description = "Safely run migrations before deployment"
 authors = [{ name = "Ryan Hiebert", email = "ryan@ryanhiebert.com" }]
 license = { text = "MIT" }
 readme = "README.rst"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 dependencies = ["django>=4.2"]
 
 [project.urls]

src/django_safemigrate/management/commands/safemigrate.py

@@ -49,9 +49,16 @@ class Command(migrate.Command):
     receiver_has_run = False
 
     def handle(self, *args, **options):
-        fake = options.get("fake", False)
-        if fake:
+        if options.get("fake") or options.get("fake_initial"):
             raise CommandError("Safemigrate does not support faking migrations.")
+        if options.get("plan"):
+            raise CommandError("Safemigrate does not support the plan option.")
+        if options.get("check_unapplied"):
+            raise CommandError("Safemigrate does not support the check_unapplied option.")
+        if options.get("prune"):
+            raise CommandError("Safemigrate does not support the prune option.")
+        if options.get("run_syncdb"):
+            raise CommandError("Safemigrate does not support the run_syncdb option.")
 
         # Only connect the handler when this command is run to
         # avoid running for tests.

tests/safemigrate_test.py

@@ -640,11 +640,20 @@ def test_migrations_detected_when_blocked_nonstrict(self, settings, receiver):
         assert len(plan) == 1
         assert SafeMigration.objects.count() == 1
 
-    def test_disallow_faking(self):
-        """Safemigrate does not support faking migrations."""
-        command = Command()
+    def test_disallow_unsupported_options(self):
+        """Early error if using an unsupported option."""
+        with pytest.raises(CommandError):
+            Command().handle(fake=True)
+        with pytest.raises(CommandError):
+            Command().handle(fake_initial=True)
+        with pytest.raises(CommandError):
+            Command().handle(plan=True)
+        with pytest.raises(CommandError):
+            Command().handle(check_unapplied=True)
+        with pytest.raises(CommandError):
+            Command().handle(prune=True)
         with pytest.raises(CommandError):
-            command.handle(fake=True)
+            Command().handle(run_syncdb=True)
         assert not SafeMigration.objects.exists()
 
     def test_migrations_are_detected(self, receiver):

tox.ini

@@ -1,11 +1,11 @@
 [tox]
 isolated_build = True
 envlist =
-    dj{42  }-py{38,39,310,311,312    }
-    dj{50  }-py{      310,311,312    }
-    dj{51  }-py{      310,311,312,313}
-    dj{52  }-py{      310,311,312,313}
-    dj{main}-py{              312,313}
+    dj{42  }-py{39,310,311,312    }
+    dj{50  }-py{   310,311,312    }
+    dj{51  }-py{   310,311,312,313}
+    dj{52  }-py{   310,311,312,313}
+    dj{main}-py{           312,313}
 
 [testenv]
 deps =