loopiloop outsourceQ #45
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added all my improvements here.
On one test I got a speedup from 0.17s to 0.12s (fortran 0.3/0.4) - per iteration
I did remove all the intel optimizations, I don't know if they would help even further, but I wanted to focus on other things first.
The code is not fully type stable, but I improved quite a bit. E.g. all the learningrate stuff is not type stable which afaik makes "B" also not type stable.
I mainly looked at the first loop, nt the update-parameter loop