Feature new test / slight refactor / new CLI #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
November 28, 2025 20:50
Collaborator
|
Yes, the reason I didn't allow pytest to auto-discover at that time was as it only sees the Otherwise, that is redundant for complete tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a second test that is not supposed to fail, and started to move already one of the test-utilities to a common file
I was hoping to be able to test the dataverse upload with a DaRus-testenvironment, but within pytest it somehow fails to add the sibling. I gave up. The (hardcoded) API key is deactivated again
I moved around slightly when what happens in terms of dataverse_create and datalad_create -> I removed the flag buisness for datalad_create, and rather just create it if it doesnt exist already.
I slightly changed that dataverse_create receives the same logger as everyone else, so I can see the output in pytest
I added some dev-packages via
uv add --dev.I removed the "test-runner" script, I think it is better to just use pytest for everything via
uv run pytestadded a github runner for the tests (fix Unit tests triggered by PR/ push events - Github Actions #38)
fixed that uv run pytest works with multiple tests. no idea why it fails - maybe some weird global state / config issue? it returns status 1 instead of already exists. maybe the second test runs somehow in the wrong environment?
@ReboreExplore is there a reason you implemented the tests by running a dedicated process instead of letting pytest discover all tests?