Skip to content

Commit 91bdd6a

Browse files
jschepersbehinger
andauthored
Apply suggestions from code review
Co-authored-by: Benedikt Ehinger <[email protected]>
1 parent 16c15b3 commit 91bdd6a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

mne_bids_pipeline/steps/preprocessing/_05b_sync_eyelink.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@ def sync_eyelink(
175175
out_files["eyelink_eeg"] = bids_basename.copy().update(processing="eyelink", suffix="raw")
176176
del bids_basename
177177

178+
# Ideally, this would be done in one of the previous steps where all folders are created (in `_01_init_derivatives_dir.py`).
178179
logger.info(**gen_log_kwargs(message=f"Create `beh` folder for eye-tracking events."))
179180
out_dir_beh = cfg.deriv_root / f"sub-{subject}"
180181
if session is not None:
@@ -298,7 +299,7 @@ def sync_eyelink(
298299
# Synchronize time stamps of ET events
299300
et_combined_df["onset"] = (et_combined_df["onset"] * first_ord + zero_ord)
300301
et_combined_df["end_time"] = (et_combined_df["end_time"] * first_ord + zero_ord)
301-
# TODO: Do we also need to "synchronize"/adapt the duration column?
302+
# TODO: To be super correct, we would need to recalculate duration column as well - but typically the slope is so close to "1" that this would typically result in <1ms differences
302303

303304
msg = f"Saving synced eye-tracking events to disk."
304305
logger.info(**gen_log_kwargs(message=msg))

0 commit comments

Comments
 (0)