forked from hoechenberger/mne-bids-pipeline
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Currently, the specification of out_files in _05b_sync_eyelink.py will only work for a single run because it's hard-coded to use the first filename (which means run 1) in the list:
bids_basename = raw_fnames[0].copy().update(processing=None, split=None, run=None) #TODO: Do we need to remove the run here?| bids_basename = raw_fnames[0].copy().update(processing=None, split=None, run=None) #TODO: Do we need to remove the run here? |
Possible solutions/alternatives:
- For now just throw an error in the case of multiple runs (since we only have one run in our experiment). Code from Bene:
if len(et_fnames)>1:
error("support for more than one run with EyeLink integration currently not implemented (it's not necessarily hard to do, but we simply didnt do it :)")
-
Move the
out_filescreation in the loop over runs. -
Adapt the
sync_eyelinkfunction to work on a single run and move the loop over runs to main (as it is done in other pipeline scripts) using theget_run_tasksfunction.e.g. https://github.com/s-ccs/mne-bids-pipeline/blob/0a870021e6ad61b2d55d1ddd8dbf6eb83bb1ba9d/mne_bids_pipeline/steps/preprocessing/_08a_apply_ica.py#L296C1-L300C14
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working