eyelink sync updates, first commit #4
Conversation
behinger
left a comment
behinger
left a comment
There was a problem hiding this comment.
very nice!
I just have very small comments. This is high quality :)
mne_bids_pipeline/_config.py
Outdated
| ???+ example "Example" | ||
| ```python | ||
| sync_heog_ch = "xpos_left" # use the xpos_left channel |
There was a problem hiding this comment.
| sync_heog_ch = "xpos_left" # use the xpos_left channel | |
| sync_heog_ch = "xpos_left" # use the xpos_left channel |
does it need to be left or right? e.g. if you have binocular recordings but switch between subjects which eye is recorded (e.g. via dominant eye), this might be tricky to adjust. Is there a already combined signal (I dont remember, but rather no, - then we could just look which eye has data?)
There was a problem hiding this comment.
it does need to be one channel. as far the code goes, it doesn't matter whether it's one eye or combined. should we consider building this combination capability in?
There was a problem hiding this comment.
and i see now that in the example it should be "sync_et_ch" not "sync_heog_ch"
There was a problem hiding this comment.
we discussed earlier using the metadata to automatically pick out out the xpos channel(s). the metadata do not seem to make any distinction between the xpos and ypos channels, unfortunately. this means some kind of keyword will have to be either specified or assumed e.g. "xpos" in our case.
also, shall we default to average of left and right eyes?
minor doc changes Co-authored-by: Benedikt Ehinger <[email protected]>
|
looks good to me! |
2 participants
This makes significant improvements to the assessment and display of eyelink synchronisations, as well as documentation of the parameters in the _config.py file.