Calib fix #6
Calib fix #6
Conversation
…more agnostic to non-numeric calibration IDs
| last_status = None | ||
| for annot in raw.annotations: | ||
| calib_match = re.match(".* Recalibration (start|end) \\| (\\d*)", annot["description"]) | ||
| calib_match = re.match(".* Recalibration (start|end) \\| (.*)", annot["description"]) |
There was a problem hiding this comment.
Could this be an option of the pipeline? E.g. someone else might name their recalibrations differently, or have none at all
There was a problem hiding this comment.
maybe something to comment on and for now continue with our lives 🙈
There was a problem hiding this comment.
how about we make it a user defined string that defaults to what it is now? or shall we make definition mandatory?
There was a problem hiding this comment.
sounds very good to me, let's keep our default for now
| cur_idx = calib_idx | ||
| cur_start_time = annot["onset"] | ||
| elif calib_status == last_status: | ||
| logger.info(**gen_log_kwargs(message=f"Encountered apparent duplicate calibration event - skipping")) |
There was a problem hiding this comment.
is it possible to print this calibration match? e.g. it could be recalibration start -> recalibration start or recalibration end -> recalibration end right?
There was a problem hiding this comment.
recalibration start -> recalibration start or recalibration end -> recalibration end right?
not sure what you mean by this.
There was a problem hiding this comment.
| logger.info(**gen_log_kwargs(message=f"Encountered apparent duplicate calibration event - skipping")) | |
| logger.info(**gen_log_kwargs(message=f"Encountered apparent duplicate calibration event (last:current => {last_status}:{calib_status})- skipping")) |
There was a problem hiding this comment.
last_status and calib_status will always per the if condition be the same. could do this instead?
| logger.info(**gen_log_kwargs(message=f"Encountered apparent duplicate calibration event - skipping")) | |
| logger.info(**gen_log_kwargs(message=f"Encountered apparent duplicate calibration event ({calib_status}, {calib_idx}) - skipping")) |
…n match string can now be user defined
2 participants
This makes mark_calibration_as_bad robust to duplicate calibration start/stop triggers, and also makes the regular expression agnostic to the ID of the trigger, i.e. the ID can be any string now, as opposed to any number