Skip to content

Conversation

@jschepers
Copy link

Changes:

  • Before the eye-tracking files needed to have task and run specified. I have now introduced two variables in the config file et_has_run and et_has_task, that indicate whether the eye-tracking file names have task and run specified or not.

    If they are set to False, it is assumed that the file name does not have task or run. If they are set to True , task and run are taken from the EEG data.

  • I commented out the _update_for_splits function calls for the eye-tracking data paths. We still need to find out whether we need them or not.

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@jschepers
Copy link
Author

I tested this functionality once for "False" once for "True" and the resulting file paths looked reasonable to me but I did not write any tests.

@jschepers jschepers requested review from behinger and jshanna100 July 21, 2025 10:23
@jschepers jschepers marked this pull request as draft July 21, 2025 11:21
@behinger
Copy link
Member

Looks good to me!

@jschepers jschepers marked this pull request as ready for review July 24, 2025 12:56
@jschepers
Copy link
Author

Thanks for having a look! Then I'll merge.

@jschepers jschepers merged commit 1073057 into temp_dev Jul 24, 2025
1 check passed
@jschepers jschepers deleted the fix-et-file-paths branch July 24, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants