Skip to content

Conversation

@jschepers
Copy link

Changes

  • Problem: In the previous version, the get_input_fnames_sync_eyelink function threw an error if the ET .asc file did not exist, because it checks whether all files with the given paths exist.
  • Solution:
    • I implemented a check which of the two files (.asc and/or .edf) exists, already in the get_input_fnames_sync_eyelink and only saved the existing file in in_files.
    • I adapted the sync_eyelink function such that it checks the file extension of the given ET files and either loads the file (if .asc) or first calls edf2asc (if .edf).

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@jschepers
Copy link
Author

I quickly tested the cases:

  • neither edf nor asc
  • only edf
  • asc and edf

But I did not do extensive testing.

@jschepers jschepers requested review from behinger and jshanna100 July 21, 2025 13:00
Copy link
Member

@behinger behinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find an obvious problem. I think you should merge.

Base automatically changed from fix-et-file-paths to temp_dev July 24, 2025 12:57
@jschepers jschepers marked this pull request as ready for review July 24, 2025 13:02
@jschepers
Copy link
Author

Thank you. I solved a small merge conflict and will merge now.

@jschepers jschepers merged commit 2366e2b into temp_dev Jul 24, 2025
1 check passed
@jschepers jschepers deleted the fix-et_file-format-handling branch July 24, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants