Skip to content

Conversation

@jschepers
Copy link

Changes & implementation decisions

  • Name eye-tracking events with suffix et_events for now
  • Create beh folder in the sync_eyelink function
  • Set find_overlaps parameter of read_raw_eyelink to False until we learn more about combining binocular data
  • Remove appending eye-tracking _raw_extras to the EEG ones because we found out it does not work this way
  • Mark all eye-tracking events in the annotations with ET and add them to the EEG annotations (instead of only marking the synchronisation events)
    • Disadvantages: We have duplicate experimental events, we have eye movement events (e.g. saccades) in the annotations as well as in the et_events.tsv
    • Advantages: It's possible to check the synchronisation using the onsets from the annotations, we don't lose events like BAD_ACQ_SKIP and don't have to put extra (custom) effort in the pipeline to extract them (but shift that to a later preprocessing step)
  • For the eye-tracking events, combine saccades, fixations and blinks data frames from _raw_extras
  • Synchronize onset and end_time of the eye-tracking events by recalculating the regression coefficients from the EEG+ET synchronisation

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@jschepers
Copy link
Author

@behinger and @jshanna100, it would be great if you could have a look at my code changes and give me some feedback.
I tested it a bit with data but I did not do any extensive or systematic testing.

Copy link
Member

@behinger behinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

Co-authored-by: Benedikt Ehinger <[email protected]>
@jschepers
Copy link
Author

@behinger I commited your code comments and moved the out_files problem to a separate issue #12
I will merge now this part.

@jschepers jschepers merged commit 2b17e0d into temp_dev Nov 25, 2025
1 check passed
@jschepers jschepers deleted the extract-and-synchronise-et-events branch November 26, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants