cranked up test coverage and found a few missing exports

Author: s-fleck

DESCRIPTION

@@ -2,7 +2,7 @@ Type: Package
 Package: dint
 Title: A Toolkit for Year-Quarter, Year-Month and Year-Isoweek
     Dates
-Version: 2.0.0.9004
+Version: 2.0.0.9005
 Authors@R: 
     person(given = "Stefan",
            family = "Fleck",

NAMESPACE

@@ -116,6 +116,9 @@ S3method(unique,date_yw)
 S3method(xtfrm,date_xx)
 export("%y+%")
 export("%y-%")
+export(Sys.date_ym)
+export(Sys.date_yq)
+export(Sys.date_yw)
 export(as_date_y)
 export(as_date_ym)
 export(as_date_yq)
@@ -157,6 +160,7 @@ export(get_month)
 export(get_quarter)
 export(get_year)
 export(is_Date)
+export(is_POSIXlt)
 export(is_date_xx)
 export(is_date_y)
 export(is_date_ym)

NEWS.md

@@ -1,6 +1,6 @@
 # dint 2.0.0.9000
 
-* added *ggplot2* scales for dint data types
+* added **ggplot2** scales for dint data types
 * added predicates to check wether dates correspond to the boundaries of 
   years or quarters (`is_quarter_bounds()`, `is_year_bounds()`, 
   `is_first_of_quarter()`, etc...)
@@ -10,6 +10,8 @@
   (the result is an `integer`)
 * added `as_yearmon()` and `as_yearqtr()` for converting to *zoo* S3 classes
 * Removed functions that were deprecated with dint 2.0.0
+* added `Sys.date_yq()`, `Sys.date_ym()` and `Sys.date_yw()` to get the current
+  quarter, month or isoweek.
 * lots of small fixes
 
 

R/date_xx.R

@@ -150,17 +150,20 @@ as.POSIXct.date_xx <- function(x, tz = "", ...){
 
 
 
-
+#' @rdname as.Date.date_xx
+#' @export
 Sys.date_yq <- function() as_date_yq(Sys.Date())
 
 
 
-
+#' @rdname as.Date.date_xx
+#' @export
 Sys.date_ym <- function() as_date_ym(Sys.Date())
 
 
 
-
+#' @rdname as.Date.date_xx
+#' @export
 Sys.date_yw <- function() as_date_yw(Sys.Date())
 
 

R/predicates.R

@@ -51,6 +51,7 @@ is_last_of_quarter <- function(
 
 
 
+
 #' @export
 #' @rdname period_bounds
 is_year_bounds <- function(
@@ -62,15 +63,17 @@ is_year_bounds <- function(
 
 
 
+
 #' @export
 #' @rdname period_bounds
-
 is_first_of_year <- function(x){
    r <- as.POSIXlt(x, tz = tz(x))
    r$mon == 0L & r$mday == 1L
 }
 
 
+
+
 #' @export
 #' @rdname period_bounds
 is_last_of_year <- function(x){
@@ -80,6 +83,7 @@ is_last_of_year <- function(x){
 
 
 
+
 #' @export
 #' @rdname period_bounds
 is_Date <- function(
@@ -91,10 +95,15 @@ is_Date <- function(
 
 
 
+#' @export
+#' @rdname period_bounds
 is_POSIXlt <- function(x){
   inherits(x, "POSIXlt")
 }
 
+
+
+
 # utils -------------------------------------------------------------------
 
 as_md_integer <- function(

R/utils.R

@@ -16,7 +16,7 @@ make_date <- function(y, m, d){
   if (requireNamespace("lubridate", quietly = TRUE)){
     lubridate::make_date(y, m, d)
   } else {
-    as.Date(ISOdate(y, m, d))
+    as.Date(ISOdate(y, m, d))  # nocov
   }
 }
 
@@ -29,8 +29,7 @@ substr_right <- function(x, n){
 }
 
 
-
-
+# nocov start
 dyn_register_s3_method <- function(
   pkg,
   generic,
@@ -61,7 +60,7 @@ dyn_register_s3_method <- function(
     }
   )
 }
-
+# nocov end
 
 
 

man/as.Date.date_xx.Rd

@@ -5,7 +5,7 @@ test_that("get_* returns integers", {
   d <- Sys.Date()
   ym <- date_ym(2018, 1)
   yq <- date_yq(2018, 1)
-
+  y <-  date_y(2018)
 
   expect_true(is.integer(get_month(d)))
   expect_true(is.integer(get_month(ym)))
@@ -19,4 +19,18 @@ test_that("get_* returns integers", {
   expect_true(is.integer(get_year(ym)))
   expect_true(is.integer(get_year(yq)))
 
+  expect_error(get_month(y))
+  expect_error(get_quarter(y))
+})
+
+
+
+test_that("lubridate accessors work", {
+  if (!requireNamespace("lubridate", quietly = TRUE)){
+    skip("test requires lubridate")
+  }
+  ym <- date_ym(2018, 1)
+  expect_identical(lubridate::year(ym), get_year(ym))
+  expect_identical(lubridate::month(ym), get_month(ym))
+  expect_identical(lubridate::quarter(ym), get_quarter(ym))
 })