treat rawMsg like all other properties

Author: s-fleck

R/LogEvent.R

@@ -53,7 +53,7 @@ LogEvent <- R6::R6Class(
       timestamp = Sys.time(),
       caller = NA,
       msg = NA,
-      .rawMsg = msg,
+      rawMsg = msg,
       ...
     ){
       assert(inherits(logger, "Logger"), "Logger must be a <Logger> object, not a ", class_fmt(logger))
@@ -65,7 +65,7 @@ LogEvent <- R6::R6Class(
       assign("timestamp", timestamp, self)
       assign("caller", caller, self)
       assign("msg", msg, self)
-      assign(".rawMsg", .rawMsg, self)
+      assign("rawMsg", rawMsg, self)
 
       # custom values
       if (!missing(...)){
@@ -98,20 +98,20 @@ LogEvent <- R6::R6Class(
     #' event (equivalent to `get_logger(event$logger)`).
     .logger = NULL,
 
-    #' @field .rawMsg `character`. The raw log message without string
+    #' @field rawMsg `character`. The raw log message without string
     #'   interpolation.
-    .rawMsg = NULL
+    rawMsg = NULL
   ),
 
   active = list(
 
     #' @field values `list`. All values stored in the `LogEvent`, including
-    #' all *custom fields*, but not including `event$.logger` and `event$.rawMsg`.
+    #' all *custom fields*, but not including `event$.logger`.
     values = function(){
       fixed_vals   <- c("level", "timestamp", "logger", "caller", "msg")
       custom_vals <- setdiff(
         names(get(".__enclos_env__", self)[["self"]]),
-        c(".__enclos_env__", "level_name", "initialize", "clone", "values", ".rawMsg",
+        c(".__enclos_env__", "level_name", "initialize", "clone", "values", "rawMsg",
           ".logger")
       )
       valnames <- union(fixed_vals, custom_vals) # to enforce order of fixed_vals

R/Logger.R

@@ -235,7 +235,7 @@ Logger <- R6::R6Class(
             timestamp = timestamp,
             caller = caller,
             msg = msg,
-            .rawMsg = rawMsg
+            rawMsg = rawMsg
           )
         } else {
           dots <- list(...)
@@ -248,7 +248,7 @@ Logger <- R6::R6Class(
               timestamp = timestamp,
               caller = caller,
               msg = msg,
-              .rawMsg = rawMsg
+              rawMsg = rawMsg
             )
           } else {
             not_named <- vapply(names(dots), is_blank, TRUE, USE.NAMES = FALSE)
@@ -263,7 +263,7 @@ Logger <- R6::R6Class(
                 timestamp = timestamp,
                 caller = caller,
                 msg = msg,
-                .rawMsg = rawMsg
+                rawMsg = rawMsg
               ),
               dots[!not_named]
             )
@@ -941,7 +941,7 @@ LoggerGlue <- R6::R6Class(
             timestamp = timestamp,
             caller = caller,
             msg = msg,
-            .rawMsg = rawMsg
+            rawMsg = rawMsg
           ),
           dots[custom_fields]
         )

tests/testthat/test_Logger.R

@@ -487,7 +487,7 @@ test_that("LoggerGlue$log - with 'msg' argument - throws a warning", {
 })
 
 
-test_that("Logger$log - with string interpolation - adds .rawMsg to event", {
+test_that("Logger$log - with string interpolation - adds rawMsg to event", {
   l <- get_logger("test")$set_propagate(FALSE)
 
   on.exit({
@@ -497,11 +497,11 @@ test_that("Logger$log - with string interpolation - adds .rawMsg to event", {
   l$info("foo %s", "bar")
 
   expect_identical(l$last_event$msg, "foo bar")
-  expect_identical(l$last_event$.rawMsg, "foo %s")
+  expect_identical(l$last_event$rawMsg, "foo %s")
 })
 
 
-test_that("LoggerGlue$log - with string interpolation - adds .rawMsg to event", {
+test_that("LoggerGlue$log - with string interpolation - adds rawMsg to event", {
   l <- get_logger_glue("testglue")$set_propagate(FALSE)
 
   on.exit({
@@ -511,6 +511,6 @@ test_that("LoggerGlue$log - with string interpolation - adds .rawMsg to event",
   l$fatal("hash {x}", x = "baz")
 
   expect_identical(as.character(l$last_event$msg), "hash baz")
-  expect_identical(l$last_event$.rawMsg, "hash {x}")
+  expect_identical(l$last_event$rawMsg, "hash {x}")
 })