as_logger_config.list no longer ignores propagate

Author: s-fleck

R/logger_config.R

@@ -91,7 +91,8 @@ as_logger_config.list <- function(x){
     threshold = x$threshold,
     filters = x$filters,
     appenders = x$appenders,
-    exception_handler = x$exception_handler
+    exception_handler = x$exception_handler,
+    propagate = x$propagate
   )
 }
 

tests/testthat/test_logger_config.R

@@ -15,6 +15,9 @@ test_that("logger_config works as expected", {
   expect_true(inherits(tl$appenders[[1]], "Appender"))
   expect_false(is_virgin_Logger(tl))
 
+  expect_silent(tl$fatal("test"))  # propagate
+  expect_equal(tl$last_event$level, 400)  # force level filter
+
   tl <- get_logger("test")$config(logger_config())
   expect_true(is_virgin_Logger(tl))
 })

tests/testthat/test_parallel.R

@@ -29,11 +29,11 @@ for (strategy in c(
     lg <- get_logger("par_root/par_child")
 
     x <- future::future(lr$info("root_logger"))
-    x <- future::value(x)
+    expect_silent(x <- future::value(x))
     expect_match(readLines(tf)[[1]], "root_logger")
 
     y <- future::future(lg$info("child_logger"))
-    y <- future::value(y)
+    expect_silent(y <- future::value(y))
     expect_match(readLines(tf)[[2]], "child_logger")
 
     future.apply::future_lapply(