Skip to content

Commit d60bf9b

Browse files
s-fleckStefan Fleck
authored andcommitted
fix moved urls in the vignette and removed Inkscape link (as we have not been using the hex sticker for a long while now)
1 parent 79020eb commit d60bf9b

File tree

5 files changed

+19
-17
lines changed

5 files changed

+19
-17
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Type: Package
22
Package: lgr
33
Title: A Fully Featured Logging Framework
4-
Version: 0.4.0
4+
Version: 0.4.1
55
Authors@R:
66
person(given = "Stefan",
77
family = "Fleck",

NEWS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# lgr 0.4.0
1+
# lgr 0.4.1
22

33
* Moved more complex Appenders to package
44
[lgrExtra](https://github.com/s-fleck/lgrExtra). This includes database

README.Rmd

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Loggers a bit strange and verbose, but care was taken to keep
3535
the syntax for common logging tasks and interactive usage simple and concise.
3636
User that have experience with
3737
[shiny](https://github.com/rstudio/shiny),
38-
[plumber](https://github.com/trestletech/plumber),
38+
[plumber](https://github.com/rstudio/plumber),
3939
[python logging](https://docs.python.org/3/library/logging.html) or
4040
[Apache Log4j](https://logging.apache.org/log4j/2.x/) will feel
4141
at home. User that are proficient with R6 classes will also find it easy
@@ -257,5 +257,4 @@ request on the issue tracker.
257257

258258
## Acknowledgement
259259

260-
* [Inkscape](https://inkscape.org/) for the hex sticker
261-
* [draw.io](https://draw.io/) for the flow chart in the vignette
260+
* [diagrams.net](https://app.diagrams.net/) for the flow chart in the vignette

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Users that have not worked with R6 classes before, will find configuring
2323
Loggers a bit strange and verbose, but care was taken to keep the syntax
2424
for common logging tasks and interactive usage simple and concise. User
2525
that have experience with [shiny](https://github.com/rstudio/shiny),
26-
[plumber](https://github.com/trestletech/plumber), [python
26+
[plumber](https://github.com/rstudio/plumber), [python
2727
logging](https://docs.python.org/3/library/logging.html) or [Apache
2828
Log4j](https://logging.apache.org/log4j/2.x/) will feel at home. User
2929
that are proficient with R6 classes will also find it easy to extend and
@@ -65,13 +65,13 @@ vignette.
6565

6666
``` r
6767
lgr$fatal("A critical error")
68-
#> FATAL [10:55:49.023] A critical error
68+
#> FATAL [17:25:32.336] A critical error
6969
lgr$error("A less severe error")
70-
#> ERROR [10:55:49.145] A less severe error
70+
#> ERROR [17:25:32.401] A less severe error
7171
lgr$warn("A potentially bad situation")
72-
#> WARN [10:55:49.202] A potentially bad situation
72+
#> WARN [17:25:32.421] A potentially bad situation
7373
lgr$info("iris has %s rows", nrow(iris))
74-
#> INFO [10:55:49.217] iris has 150 rows
74+
#> INFO [17:25:32.425] iris has 150 rows
7575

7676
# the following log levels are hidden by default
7777
lgr$debug("A debug message")
@@ -85,9 +85,9 @@ appender to log to a file with little effort.
8585
tf <- tempfile()
8686
lgr$add_appender(AppenderFile$new(tf, layout = LayoutJson$new()))
8787
lgr$info("cars has %s rows", nrow(cars))
88-
#> INFO [10:55:49.270] cars has 50 rows
88+
#> INFO [17:25:32.458] cars has 50 rows
8989
cat(readLines(tf))
90-
#> {"level":400,"timestamp":"2020-10-17 10:55:49","logger":"root","caller":"eval","msg":"cars has 50 rows"}
90+
#> {"level":400,"timestamp":"2020-10-17 17:25:32","logger":"root","caller":"eval","msg":"cars has 50 rows"}
9191
```
9292

9393
By passing a named argument to `info()`, `warn()`, and co you can log
@@ -97,10 +97,10 @@ logfiles that are machine as well as (somewhat) human readable.
9797

9898
``` r
9999
lgr$info("loading cars", "cars", rows = nrow(cars), cols = ncol(cars))
100-
#> INFO [10:55:49.322] loading cars {rows: 50, cols: 2}
100+
#> INFO [17:25:32.502] loading cars {rows: 50, cols: 2}
101101
cat(readLines(tf), sep = "\n")
102-
#> {"level":400,"timestamp":"2020-10-17 10:55:49","logger":"root","caller":"eval","msg":"cars has 50 rows"}
103-
#> {"level":400,"timestamp":"2020-10-17 10:55:49","logger":"root","caller":"eval","msg":"loading cars","rows":50,"cols":2}
102+
#> {"level":400,"timestamp":"2020-10-17 17:25:32","logger":"root","caller":"eval","msg":"cars has 50 rows"}
103+
#> {"level":400,"timestamp":"2020-10-17 17:25:32","logger":"root","caller":"eval","msg":"loading cars","rows":50,"cols":2}
104104
```
105105

106106
For more examples please see the package
@@ -243,5 +243,5 @@ to post a feature request on the issue tracker.
243243

244244
## Acknowledgement
245245

246-
- [Inkscape](https://inkscape.org/) for the hex sticker
247-
- [draw.io](https://draw.io/) for the flow chart in the vignette
246+
- [diagrams.net](https://app.diagrams.net/) for the flow chart in the
247+
vignette

cran-comments.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,6 @@
1212

1313
Major update (see NEWS.md). Fixes CRAN check errors that are due to a breaking
1414
update in the companion-package rotor.
15+
16+
17+
**resubmission:** fixed some outdated URLs that have moved

0 commit comments

Comments
 (0)