some (possibly rediculous) performance improvements

Author: Stefan Fleck

R/Logger.R

@@ -632,6 +632,7 @@ Logger <- R6::R6Class(
     }
   ),
 
+
   # active bindings ---------------------------------------------------------
   active = list(
     name = function(){
@@ -676,15 +677,15 @@ Logger <- R6::R6Class(
     threshold = function() {
       res <- get(".threshold", envir = private)
       if (is.null(res)){
-        get("parent", envir = self)[["threshold"]]
+        get("threshold", envir = get("parent", envir = self))
       } else {
         res
       }
     },
 
 
     inherited_appenders = function(){
-      if (self$propagate){
+      if (get(".propagate", envir = private)){
         c(
           get("parent", envir = self)$appenders,
           get("parent", envir = self)$inherited_appenders
@@ -694,11 +695,15 @@ Logger <- R6::R6Class(
       }
     },
 
-    exception_handler = function() {private$.exception_handler},
 
+    exception_handler = function() {
+      get(".exception_handler", envir = private)
+    },
 
-    appenders = function() {private$.appenders}
 
+    appenders = function() {
+      get(".appenders", envir = private)
+    }
   ),
 
 

R/get_logger.R

@@ -54,7 +54,6 @@ get_logger <- function(
 
   assert(is.character(name))
   assert(is_scalar_bool(reset))
-  assert(R6::is.R6Class(class), "`class` must be an R6ClassGenerator")
 
   nm_cur <- unlist(strsplit(name, "/", fixed = TRUE))
   name   <- paste(nm_cur, collapse = "/")
@@ -71,15 +70,12 @@ get_logger <- function(
   }
 
   if (is.null(res)){
+    assert(R6::is.R6Class(class), "`class` must be an R6ClassGenerator")
     assign(name, class$new(name), envir = loggers, inherits = FALSE)
     return(get_logger(name, class = class))
   }
 
-  if (class$classname %in% class(res)){
-    return(res)
-  } else {
-    stop(sprintf("'%s' is a %s but not a %s", name, class_fmt(res), fmt_class(class$classname)))
-  }
+  res
 }