* fixes time zone related issue in Cache$prune().

* fixes bug in `rotate_rds(on_change_only = TRUE)` that occurs if a version
  of data.table < 1.3.0 is installed and either the source or target object are a
  `data.table` (but not both)
* more robust clean up of temporary files in most unit tests

Author: s-fleck

CRAN-RELEASE

@@ -0,0 +1,2 @@
+This package was submitted to CRAN on 2020-10-18.
+Once it is accepted, delete this file and tag the release (commit 18db480cc6).

DESCRIPTION

@@ -1,7 +1,7 @@
 Type: Package
 Package: rotor
 Title: Log Rotation and Conditional Backups
-Version: 0.3.0
+Version: 0.3.1
 Authors@R: 
     person(given = "Stefan",
            family = "Fleck",

NEWS.md

@@ -1,3 +1,12 @@
+# rotor 0.3.1
+
+* fixes time zone related issue in `Cache$prune()`.
+* fixes bug in `rotate_rds(on_change_only = TRUE)` that occurs if a version
+  of data.table < 1.3.0 is installed and either the source or target object are a 
+  `data.table` (but not both)
+* more robust clean up of temporary files in most unit tests 
+
+
 # rotor 0.3.0
 
 * Improved some error messages

R/BackupQueue.R

@@ -935,7 +935,7 @@ select_prune_files_by_age <- function(
       limit <- dint::first_of_isoweek(dint::as_date_yw(now) - max_age$value + 1L)
 
     } else if (identical(max_age[["unit"]], "day")){
-      limit <- as.Date(now) - max_age$value + 1L
+      limit <- as.Date(as.character(now)) - max_age$value + 1L
     }
 
     to_remove <- path[as.Date(as.character(timestamp)) < limit]

R/Cache.R

@@ -134,7 +134,7 @@ Cache <- R6::R6Class(
       assert(is.null(max_files) || is.infinite(max_files) || is_n0(max_files))
       files <- self$files
       files <- files[order(files$mtime), ]
-      now <- as.Date(now)
+      now <- as.Date(as.character(now))
 
       rem <- list()
 

R/rotate_rds.R

@@ -137,9 +137,10 @@ rotate_rds_internal <- function(
   if (file.exists(file)){
     if (on_change_only){
       comp <- readRDS(file)
+
       if (
         identical(object, comp) ||
-        (inherits(object, "data.table") && assert_namespace("data.table") && isTRUE(all.equal(object, comp)))
+        (inherits(object, "data.table") && inherits(comp, "data.table") && assert_namespace("data.table") && isTRUE(all.equal(object, comp)))
       ){
         message(ObjectHasNotChangedMessage("not rotating: object has not changed"))
         return(invisible(file))

cran-comments.md

@@ -1,11 +1,30 @@
 ## Test environments
+* ubuntu 20.04, R 4.0.2
 * ubuntu 18.04 (via RStudio Server), R 4.0.2
 * ubuntu 16.04 (via travis), R 3.6.1
-* win-builder (devel)
+* win-builder, R devel
+* macOS 10.13.6 High Sierra, R-release, brew (via Rhub) 
 * rhub::check_for_cran()
 
 ## R CMD check results
 
 0 errors | 0 warnings | 0 notes
 
-added new functionality (see NEWS.md)
+* fixes time zone related issue in `Cache$prune()` that causes macOS tests to fail
+* more robust cleanup of temporary files between some tests
+* resubmission that improves one test where 
+  `https://cran.r-project.org/web/checks/check_results_rotor.html` shows an
+  error that I could not reproduce on any machine available on rhub. 
+  Hopefully the test succeedes now, but if not it will give me more useful 
+  debug information for another resubmission.
+
+
+Notes:
+
+There was a timezone related issue that only occured on macos. I fixed it and
+was able to test it on macOS 10.13.6 High Sierra with R-release (but not devel)
+on Rhub.
+
+I could not reproduce the other errors; however, it looks as if they were caused
+by improperly cleaned-up temporary files between failing tests. I made the
+cleanup code a bit more robust and hope the problem is fixed now.