-
Notifications
You must be signed in to change notification settings - Fork 1
TextUtils.formatDate: take DateFormat not DisplayOptions #228
Copy link
Copy link
Open
Labels
need changeBreaking change. Enhance or modify the current implementation in an observable way.Breaking change. Enhance or modify the current implementation in an observable way.qualityCross-cutting polish; eventually pair with another work-type labelCross-cutting polish; eventually pair with another work-type labelquestionFurther information is requestedFurther information is requested
Metadata
Metadata
Assignees
Labels
need changeBreaking change. Enhance or modify the current implementation in an observable way.Breaking change. Enhance or modify the current implementation in an observable way.qualityCross-cutting polish; eventually pair with another work-type labelCross-cutting polish; eventually pair with another work-type labelquestionFurther information is requestedFurther information is requested
TextUtils.formatDatetakesDisplayOptionsbut is a low-level helper; pullingdate.formatfrom broad options couples date rendering to global display config.Location:
src/displayable.mts:350Code:
Possible approach: Split API:
formatDate(date: Date | number, format: DateFormat)and keep a thin wrapper forDisplayOptionsat call sites that need it.