Fixed bug in release 0.1.5

Author: saad1998

cfn_inline_lambda_linter/linter.py

@@ -104,26 +104,26 @@ def extractLambdaCode(resources, parameters, dict_to_check, args=None):
                         if "python" in val:
                             if args is None:
                                 process = subprocess.Popen(
-                                    ['python', '-m', 'flake8', "-", "--ignore=F828"],
+                                    ['python', '-m', 'flake8', "-", "--ignore=F821"],
                                     stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
                                 )
                             else:
-                                if "F828" in args:    
+                                if "F821" in args:    
                                     process = subprocess.Popen(
                                         ['python', '-m', 'flake8', "-"] + args.split(),
                                         stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
                                     )
                                 else:
                                     if "--ignore" in args:
-                                        y=args.split("--ignore=")[1] + ",F828"
+                                        y=args.split("--ignore=")[1] + ",F821"
                                         z=args.split("--ignore")[:-1] + ["--ignore=" + y]
                                         process = subprocess.Popen(
                                             ['python', '-m', 'flake8', "-"] + z,
                                             stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
                                         )
                                     else:
                                         process = subprocess.Popen(
-                                            ['python', '-m', 'flake8', "-", "--ignore=F828"] + args.split(),
+                                            ['python', '-m', 'flake8', "-", "--ignore=F821"] + args.split(),
                                             stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
                                         )
                         else:
@@ -140,26 +140,26 @@ def extractLambdaCode(resources, parameters, dict_to_check, args=None):
                     if "python" in programming_lang:
                         if args is None:
                             process = subprocess.Popen(
-                                ['python', '-m', 'flake8', "-", "--ignore=F828"],
+                                ['python', '-m', 'flake8', "-", "--ignore=F821"],
                                 stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
                             )
                         else:
-                            if "F828" in args:    
+                            if "F821" in args:    
                                 process = subprocess.Popen(
                                     ['python', '-m', 'flake8', "-"] + args.split(),
                                     stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
                                 )
                             else:
                                 if "--ignore" in args:
-                                    y=args.split("--ignore=")[1] + ",F828"
+                                    y=args.split("--ignore=")[1] + ",F821"
                                     z=args.split("--ignore")[:-1] + ["--ignore=" + y]
                                     process = subprocess.Popen(
                                         ['python', '-m', 'flake8', "-"] + z,
                                         stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
                                     )
                                 else:
                                     process = subprocess.Popen(
-                                        ['python', '-m', 'flake8', "-", "--ignore=F828"] + args.split(),
+                                        ['python', '-m', 'flake8', "-", "--ignore=F821"] + args.split(),
                                         stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE
                                     )
                     else:

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "cfn-inline-lambda-linter"
-version = "0.1.5"
+version = "0.1.6"
 description = "Prints out linting errors found in inline cloudformation lambda code"
 authors = ["Saad Mohsin Khan <saadk687@gmail.com>"]
 license = "MIT"

tests/integration_tests/test_linter_end_to_end.py

@@ -85,8 +85,8 @@ def test_linter_simple_yaml_not_cloudformation(tmp_path, monkeypatch):
     # Should exit with code 0 (success) since it's skipping the file
     assert exc_info.value.code == 0
 
-def test_linter_lambda_with_sub_function_ignores_f828(tmp_path, monkeypatch):
-    """Test that F828 errors are ignored when Lambda code uses !Sub with CloudFormation parameters/resources"""
+def test_linter_lambda_with_sub_function_ignores_f821(tmp_path, monkeypatch):
+    """Test that F821 errors are ignored when Lambda code uses !Sub with CloudFormation parameters/resources"""
     file_path = tmp_path / "lambda_with_sub_template.yaml"
     file_path.write_text("""
     Parameters:

tests/unit_tests/test_extractLambdaCode.py

@@ -45,34 +45,34 @@ def test_extract_lambda_code_missing_zipfile():
     # Should skip and leave status unchanged (or set to a specific value if your logic does)
     assert result["LambdaFunction"]["status"] == "SkippingLambda"
 
-def test_extract_lambda_code_ignore_f828():
-    """Test that F828 errors are ignored when Lambda code uses CloudFormation substitutions."""
+def test_extract_lambda_code_ignore_f821():
+    """Test that F821 errors are ignored when Lambda code uses CloudFormation substitutions."""
     resources = {
         "LambdaFunction": {
             "Type": "AWS::Lambda::Function",
             "Properties": {
                 "Runtime": "python3.8",
                 "Code": {
-                    "ZipFile": "import boto3\nimport json\n\n# This would normally trigger F828 - undefined name\nmy_resource = ${MyResource}\nbucket_name = ${BucketName}\n\ndef handler(event, context):\n    return {'statusCode': 200}"
+                    "ZipFile": "import boto3\nimport json\n\n# This would normally trigger F821 - undefined name\nmy_resource = ${MyResource}\nbucket_name = ${BucketName}\n\ndef handler(event, context):\n    return {'statusCode': 200}"
                 }
             }
         }
     }
     dict_to_check = {"LambdaFunction": {"status": "CodeNotFormatted"}}
     result = extractLambdaCode(resources, {}, dict_to_check, args=None)
 
-    # The linter should ignore F828 errors and not report them as failures
+    # The linter should ignore F821 errors and not report them as failures
     errors = result["LambdaFunction"].get("errors", "")
-    assert "F828" not in errors, "F828 should be ignored for CloudFormation substitutions"
+    assert "F821" not in errors, "F821 should be ignored for CloudFormation substitutions"
 
-    # Since we're ignoring F828, the status should be FoundNoErrors (other errors might still exist)
-    # But F828 specifically should not be present
+    # Since we're ignoring F821, the status should be FoundNoErrors (other errors might still exist)
+    # But F821 specifically should not be present
     if result["LambdaFunction"]["status"] == "FoundErrors":
-        # If there are errors, make sure F828 is not one of them
-        assert "F828" not in errors
+        # If there are errors, make sure F821 is not one of them
+        assert "F821" not in errors
 
-def test_extract_lambda_code_ignore_f828_with_custom_args():
-    """Test that F828 is still ignored when custom flake8 args are provided."""
+def test_extract_lambda_code_ignore_f821_with_custom_args():
+    """Test that F821 is still ignored when custom flake8 args are provided."""
     resources = {
         "LambdaFunction": {
             "Type": "AWS::Lambda::Function",
@@ -86,14 +86,14 @@ def test_extract_lambda_code_ignore_f828_with_custom_args():
     }
     dict_to_check = {"LambdaFunction": {"status": "CodeNotFormatted"}}
 
-    # Test with custom args that don't mention F828
+    # Test with custom args that don't mention F821
     result = extractLambdaCode(resources, {}, dict_to_check, args="--max-line-length=120")
 
     errors = result["LambdaFunction"].get("errors", "")
-    assert "F828" not in errors, "F828 should be ignored even with custom args"
+    assert "F821" not in errors, "F821 should be ignored even with custom args"
 
-def test_extract_lambda_code_ignore_f828_with_parameter_ref():
-    """Test that F828 is ignored when Runtime is referenced via parameter."""
+def test_extract_lambda_code_ignore_f821_with_parameter_ref():
+    """Test that F821 is ignored when Runtime is referenced via parameter."""
     resources = {
         "LambdaFunction": {
             "Type": "AWS::Lambda::Function",
@@ -115,4 +115,4 @@ def test_extract_lambda_code_ignore_f828_with_parameter_ref():
     result = extractLambdaCode(resources, parameters, dict_to_check, args=None)
 
     errors = result["LambdaFunction"].get("errors", "")
-    assert "F828" not in errors, "F828 should be ignored for parameter referenced runtime"
+    assert "F821" not in errors, "F821 should be ignored for parameter referenced runtime"