Skip to content

bug: daisyui.com navigation broken when beacon.enabled = false in firefox #3681

Description

@voidus

Reproduction URL (Required)

https://daisyui.com

What version of daisyUI are you using?

No response

Which browsers are you seeing the problem on?

Firefox

Describe your issue

Go to about:config, set beacon.enable to false and visit daisyui.com. The navigation will update the url but won't change the content. Clicking a link in the navigation and then reloading the page will actually navigate, but that's no way to live.

The devtools console says Uncaught (in promise) TypeError: navigator.sendBeacon is not a function, which should probably be caught and, from a data protection standpoint, be ignored.

My understanding is that this is used for analytics, in particular when trying to send something before the browser unloads the page. Since daisyui doesn't actually unload (at least in this case) we could fall back to fetch.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions