Skip to content

Commit a9352e1

Browse files
authored
Merge pull request #42 from saalfeldlab/fix/local-scripts-modules
fix: local script module issues for java 17
2 parents 4fc77c0 + d6fd5e8 commit a9352e1

13 files changed

Lines changed: 35 additions & 37 deletions

startup-scripts/jar_path_util.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,16 @@ def get_local_jar_path():
66
def get_provided_jar_path():
77
return get_jar_path('-provided')
88

9+
10+
def get_java_cmd_local(class_arg):
11+
return [ 'java',
12+
'--add-opens=java.base/java.nio=ALL-UNNAMED',
13+
'--add-opens=java.base/java.lang.invoke=ALL-UNNAMED',
14+
'--add-opens=java.base/java.util=ALL-UNNAMED',
15+
'--add-exports=java.base/sun.nio.ch=ALL-UNNAMED',
16+
'-Dspark.master=local[*]', '-cp', get_local_jar_path(),
17+
class_arg]
18+
919
def get_jar_path(jar_suffix=None):
1020
curr_script_dir = os.path.dirname(os.path.abspath(__file__))
1121
base_folder = os.path.dirname(curr_script_dir)
@@ -29,4 +39,4 @@ def get_jar_path(jar_suffix=None):
2939
jar_filename_ext = os.path.splitext(jar_filename)
3040
jar_filename = jar_filename_ext[0] + jar_suffix + jar_filename_ext[1]
3141

32-
return os.path.join(target_folder, jar_filename)
42+
return os.path.join(target_folder, jar_filename)

startup-scripts/spark-local/n5-connected-components.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.N5ConnectedComponentsSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.N5ConnectedComponentsSpark') + sys.argv[1:])

startup-scripts/spark-local/n5-convert.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.N5ConvertSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.N5ConvertSpark') + sys.argv[1:])

startup-scripts/spark-local/n5-downsample-label.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.downsample.N5LabelDownsamplerSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.downsample.N5LabelDownsamplerSpark') + sys.argv[1:])

startup-scripts/spark-local/n5-downsample-offset.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.downsample.N5OffsetDownsamplerSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.downsample.N5OffsetDownsamplerSpark') + sys.argv[1:])

startup-scripts/spark-local/n5-downsample.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.downsample.N5DownsamplerSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.downsample.N5DownsamplerSpark') + sys.argv[1:])

startup-scripts/spark-local/n5-mips.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.N5MaxIntensityProjectionSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.N5MaxIntensityProjectionSpark') + sys.argv[1:])

startup-scripts/spark-local/n5-remove.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.N5RemoveSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.N5RemoveSpark') + sys.argv[1:])

startup-scripts/spark-local/n5-scale-pyramid-nonisotropic.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.downsample.scalepyramid.N5NonIsotropicScalePyramidSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.downsample.scalepyramid.N5NonIsotropicScalePyramidSpark') + sys.argv[1:])

startup-scripts/spark-local/n5-scale-pyramid-offset.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
sys.dont_write_bytecode = True
88
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
9-
from jar_path_util import get_local_jar_path
10-
bin_path = get_local_jar_path()
9+
from jar_path_util import get_java_cmd_local
1110

12-
subprocess.call(['java', '-Dspark.master=local[*]', '-cp', bin_path, 'org.janelia.saalfeldlab.n5.spark.downsample.scalepyramid.N5OffsetScalePyramidSpark'] + sys.argv[1:])
11+
subprocess.call(get_java_cmd_local('org.janelia.saalfeldlab.n5.spark.downsample.scalepyramid.N5OffsetScalePyramidSpark') + sys.argv[1:])

0 commit comments

Comments
 (0)