Skip to content

Commit 34ec536

Browse files
committed
fix: test and imports for ZARR3 StorageFormat
Signed-off-by: Caleb Hulbert <cmhulbert@gmail.com>
1 parent 4766276 commit 34ec536

4 files changed

Lines changed: 9 additions & 8 deletions

File tree

src/main/java/org/janelia/saalfeldlab/n5/universe/N5Factory.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@
2929
import com.google.cloud.storage.Storage;
3030
import com.google.cloud.storage.StorageOptions;
3131
import com.google.gson.GsonBuilder;
32-
import com.sun.tools.javac.util.List;
3332
import net.imglib2.util.Pair;
3433
import org.apache.commons.lang3.function.TriFunction;
3534
import org.janelia.saalfeldlab.googlecloud.GoogleCloudUtils;
3635
import org.janelia.saalfeldlab.n5.FileSystemKeyValueAccess;
3736
import org.janelia.saalfeldlab.n5.KeyValueAccess;
3837
import org.janelia.saalfeldlab.n5.N5Exception;
38+
import org.janelia.saalfeldlab.n5.N5Exception.N5IOException;
3939
import org.janelia.saalfeldlab.n5.N5KeyValueReader;
4040
import org.janelia.saalfeldlab.n5.N5KeyValueWriter;
4141
import org.janelia.saalfeldlab.n5.N5Reader;
@@ -59,6 +59,7 @@
5959
import java.net.URISyntaxException;
6060
import java.nio.file.Paths;
6161
import java.util.Arrays;
62+
import java.util.List;
6263
import java.util.function.BiFunction;
6364
import java.util.function.Consumer;
6465
import java.util.regex.Pattern;
@@ -452,13 +453,13 @@ public N5Reader openReader(@Nullable final StorageFormat storage, @Nullable fina
452453
* @return an N5Reader
453454
*/
454455
private N5Reader newGenericZarrReader(final KeyValueAccess access, final URI location) {
455-
for (StorageFormat zarrFormat : List.of(ZARR3, ZARR2)) {
456+
for (StorageFormat zarrFormat : Arrays.asList(ZARR3, ZARR2)) {
456457
try {
457458
return openReader(zarrFormat, access, location);
458459
} catch (Exception ignored) {
459460
}
460461
}
461-
throw new N5Exception("Unable to open Zarr reader at " + location.toString() + " as N5Reader");
462+
throw new N5IOException("Unable to open Zarr reader at " + location.toString() + " as N5Reader");
462463
}
463464

464465
/**
@@ -683,7 +684,7 @@ public N5Writer openWriter(@Nullable final StorageFormat storage, @Nullable fina
683684
* @return the zarr writer
684685
*/
685686
private N5Writer newGenericZarrWriter(final KeyValueAccess access, final URI location) {
686-
List<StorageFormat> zarrFormats = List.of(ZARR3, ZARR2);
687+
List<StorageFormat> zarrFormats = Arrays.asList(ZARR3, ZARR2);
687688
for (StorageFormat zarrFormat : zarrFormats) {
688689
/* we dont care about the read, but we do want to prefer a writer over a container that
689690
* exists, rather than creating a new writer; the only way to check is to see if
@@ -701,7 +702,7 @@ private N5Writer newGenericZarrWriter(final KeyValueAccess access, final URI loc
701702
}
702703
}
703704

704-
throw new N5Exception("Unable to open Zarr writer at " + location.toString() + " as N5Reader");
705+
throw new N5IOException("Unable to open Zarr writer at " + location.toString() + " as N5Reader");
705706
}
706707

707708
private <T extends N5Reader> T openN5ContainerWithStorageFormat(

src/test/java/org/janelia/saalfeldlab/n5/universe/StorageSchemeWrappedN5Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ default N5Writer getWriter(String uri) {
2828
final String uriWithStorageScheme = prependStorageScheme(uri);
2929
final GsonKeyValueN5Writer writer = (GsonKeyValueN5Writer)getFactory().openWriter(uriWithStorageScheme);
3030
switch (getStorageFormat()){
31-
case ZARR:
31+
case ZARR3:
3232
assertTrue(writer instanceof ZarrV3KeyValueWriter);
3333
break;
3434
case ZARR2:

src/test/java/org/janelia/saalfeldlab/n5/universe/storage/zarr/ZarrStorageTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public Zarr3FactoryTest() {
5555

5656
@Override public StorageFormat getStorageFormat() {
5757

58-
return StorageFormat.ZARR;
58+
return StorageFormat.ZARR3;
5959
}
6060

6161
@Override protected N5Writer createN5Writer() {

src/test/java/org/janelia/saalfeldlab/n5/universe/storage/zarr/zarr3/Zarr3HttpFactoryTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public static void removeClassTempWriters() {
111111
final GsonKeyValueN5Writer writer = (GsonKeyValueN5Writer)getFactory().openWriter(uriWithStorageScheme);
112112
final GsonKeyValueN5Reader reader = (GsonKeyValueN5Reader)getReader(uri);
113113
switch (getStorageFormat()) {
114-
case ZARR:
114+
case ZARR3:
115115
assertTrue(writer instanceof ZarrV3KeyValueWriter);
116116
return new ZarrV3HttpReaderFsWriter((ZarrV3KeyValueWriter)writer, (ZarrV3KeyValueReader)reader);
117117
case ZARR2:

0 commit comments

Comments
 (0)