test: slice testing works on unmaterialized ReadData

* rename helper method
* rm unused byte[]

Author: bogovicj

src/test/java/org/janelia/saalfeldlab/n5/readdata/ReadDataTests.java

@@ -35,7 +35,7 @@ public void testLazyReadData() throws IOException {
 		assertTrue(readData instanceof LazyReadData);
 
 		readDataTestHelper(readData, N);
-		splittableReadDataTestHelper(readData.materialize(), N);
+		sliceTestHelper(readData, N);
 	}
 
 	@Test
@@ -51,17 +51,13 @@ public void testByteArrayReadData() throws IOException {
 
 		readDataTestHelper(readData, N);
 		readDataTestEncodeHelper(readData, N);
-		splittableReadDataTestHelper(readData, N);
+		sliceTestHelper(readData, N);
 	}
 
 	@Test
 	public void testInputStreamReadData() throws IOException {
 
 		final int N = 128;
-		byte[] data = new byte[N];
-		for( int i = 0; i < N; i++ )
-			data[i] = (byte)i;
-
 		final InputStream is = new InputStream() {
 			int val = 0;
 			@Override
@@ -72,7 +68,7 @@ public int read() throws IOException {
 
 		final ReadData readData = ReadData.from(is, N);
 		readDataTestHelper(readData, N);
-		splittableReadDataTestHelper(readData.materialize(), N);
+		sliceTestHelper(readData, N);
 	}
 
 	@Test
@@ -93,7 +89,7 @@ public void testFileKvaReadData() throws IOException {
 				.createReadData(tmpF.getAbsolutePath());
 
 		assertEquals("file read data length", 128, readData.length());
-		splittableReadDataTestHelper(readData, N);
+		sliceTestHelper(readData, N);
 	}
 
 	private void readDataTestHelper( ReadData readData, int N ) throws IOException {
@@ -117,7 +113,7 @@ private void readDataTestEncodeHelper( ReadData readData, int N ) throws IOExcep
 		assertArrayEquals(origCopy, encodedTwice.allBytes());
 	}
 
-	private void splittableReadDataTestHelper( ReadData readData, int N ) throws IOException {
+	private void sliceTestHelper( ReadData readData, int N ) throws IOException {
 
 		assertEquals("length one", 1, readData.slice(9, 1).length());