Skip to content

Commit ee8612c

Browse files
tpietzschcmhulbert
authored andcommitted
rename prefetching LazyReads to "...PrefetchLazyRead"
instead of "...SliceTracking..." which is not their main feature
1 parent a7ef2f1 commit ee8612c

5 files changed

Lines changed: 19 additions & 10 deletions

File tree

src/main/java/org/janelia/saalfeldlab/n5/readdata/VolatileReadData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.janelia.saalfeldlab.n5.readdata;
22

33
import org.janelia.saalfeldlab.n5.N5Exception.N5IOException;
4-
import org.janelia.saalfeldlab.n5.readdata.prefetch.AggregatingSliceTrackingLazyRead;
4+
import org.janelia.saalfeldlab.n5.readdata.prefetch.AggregatingPrefetchLazyRead;
55

66
/**
77
* During its life-time, the content of a {@code VolatileReadData} should not be
@@ -29,7 +29,7 @@ public interface VolatileReadData extends ReadData, AutoCloseable {
2929
* @return a new VolatileReadData
3030
*/
3131
static VolatileReadData from(final LazyRead lazyRead) {
32-
final LazyRead aggregatingLazyRead = new AggregatingSliceTrackingLazyRead(lazyRead);
32+
final LazyRead aggregatingLazyRead = new AggregatingPrefetchLazyRead(lazyRead);
3333
return new LazyReadData(aggregatingLazyRead);
3434
}
3535

src/main/java/org/janelia/saalfeldlab/n5/readdata/prefetch/AggregatingSliceTrackingLazyRead.java renamed to src/main/java/org/janelia/saalfeldlab/n5/readdata/prefetch/AggregatingPrefetchLazyRead.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,14 @@
66
import org.janelia.saalfeldlab.n5.readdata.LazyRead;
77
import org.janelia.saalfeldlab.n5.readdata.Range;
88

9-
public class AggregatingSliceTrackingLazyRead extends SliceTrackingLazyRead {
9+
/**
10+
* A {@link SliceTrackingLazyRead} that implements {@link #prefetch} to
11+
* aggregate overlapping / adjacent ranges and then materialize each aggregated
12+
* range.
13+
*/
14+
public class AggregatingPrefetchLazyRead extends SliceTrackingLazyRead {
1015

11-
public AggregatingSliceTrackingLazyRead(final LazyRead delegate) {
16+
public AggregatingPrefetchLazyRead(final LazyRead delegate) {
1217
super(delegate);
1318
}
1419

src/main/java/org/janelia/saalfeldlab/n5/readdata/prefetch/DefaultSliceTrackingLazyRead.java renamed to src/main/java/org/janelia/saalfeldlab/n5/readdata/prefetch/EnclosingPrefetchLazyRead.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,13 @@
55
import org.janelia.saalfeldlab.n5.readdata.LazyRead;
66
import org.janelia.saalfeldlab.n5.readdata.Range;
77

8-
public class DefaultSliceTrackingLazyRead extends SliceTrackingLazyRead {
8+
/**
9+
* A {@link SliceTrackingLazyRead} that implements {@link #prefetch} to
10+
* materialize the bounding range of all requested ranges.
11+
*/
12+
public class EnclosingPrefetchLazyRead extends SliceTrackingLazyRead {
913

10-
public DefaultSliceTrackingLazyRead(final LazyRead delegate) {
14+
public EnclosingPrefetchLazyRead(final LazyRead delegate) {
1115
super(delegate);
1216
}
1317

src/test/java/org/janelia/saalfeldlab/n5/kva/TrackingKeyValueAccess.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import org.janelia.saalfeldlab.n5.readdata.LazyRead;
66
import org.janelia.saalfeldlab.n5.readdata.ReadData;
77
import org.janelia.saalfeldlab.n5.readdata.VolatileReadData;
8-
import org.janelia.saalfeldlab.n5.readdata.prefetch.AggregatingSliceTrackingLazyRead;
8+
import org.janelia.saalfeldlab.n5.readdata.prefetch.AggregatingPrefetchLazyRead;
99

1010
public class TrackingKeyValueAccess extends DelegateKeyValueAccess {
1111

@@ -31,7 +31,7 @@ public VolatileReadData createReadData(final String normalPath) {
3131
final TrackingLazyRead trackingLazyRead = new TrackingLazyRead(volatileReadData);
3232
LazyRead lazyRead = trackingLazyRead;
3333
if (aggregate)
34-
lazyRead = new AggregatingSliceTrackingLazyRead(trackingLazyRead);
34+
lazyRead = new AggregatingPrefetchLazyRead(trackingLazyRead);
3535
return VolatileReadData.from( lazyRead );
3636
}
3737

src/test/java/org/janelia/saalfeldlab/n5/readdata/prefetch/SliceTrackingLazyReadTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ private static void assertStoredSlices(TestableSliceTracker sliceTracking, List<
160160
/**
161161
* Testable wrapper for DefaultSliceTrackingLazyRead that exposes slices.
162162
*/
163-
static class TestableDefaultSliceTracker extends DefaultSliceTrackingLazyRead implements TestableSliceTracker {
163+
static class TestableDefaultSliceTracker extends EnclosingPrefetchLazyRead implements TestableSliceTracker {
164164
public TestableDefaultSliceTracker(LazyRead delegate) {
165165
super(delegate);
166166
}
@@ -174,7 +174,7 @@ public List<Range> getSlices() {
174174
/**
175175
* Testable wrapper for AggregatingSliceTrackingLazyRead that exposes slices.
176176
*/
177-
static class TestableAggregatingSliceTracker extends AggregatingSliceTrackingLazyRead implements TestableSliceTracker {
177+
static class TestableAggregatingSliceTracker extends AggregatingPrefetchLazyRead implements TestableSliceTracker {
178178
public TestableAggregatingSliceTracker(LazyRead delegate) {
179179
super(delegate);
180180
}

0 commit comments

Comments
 (0)