-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathrpc_test.go
More file actions
696 lines (631 loc) · 21.4 KB
/
Copy pathrpc_test.go
File metadata and controls
696 lines (631 loc) · 21.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
package acpruntime
import (
"bytes"
"context"
"encoding/json"
"io"
"reflect"
"strings"
"sync"
"testing"
"time"
)
func TestPeerNotifyWritesJSONRPCFrame(t *testing.T) {
var out bytes.Buffer
peer := NewPeer(strings.NewReader(""), &out, PeerOptions{})
err := peer.NotifyRaw(context.Background(), "session/cancel", json.RawMessage(`{"sessionId":"s1"}`))
if err != nil {
t.Fatalf("NotifyRaw() error = %v", err)
}
const want = `{"jsonrpc":"2.0","method":"session/cancel","params":{"sessionId":"s1"}}` + "\n"
if out.String() != want {
t.Fatalf("frame = %q, want %q", out.String(), want)
}
}
func TestPeerCallRawRoundTrip(t *testing.T) {
clientReader, serverWriter := io.Pipe()
serverReader, clientWriter := io.Pipe()
defer clientReader.Close()
defer serverWriter.Close()
defer serverReader.Close()
defer clientWriter.Close()
client := NewPeer(clientReader, clientWriter, PeerOptions{})
server := NewPeer(serverReader, serverWriter, PeerOptions{})
server.RegisterRequest("echo", func(ctx context.Context, raw json.RawMessage) (any, error) {
return raw, nil
})
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
go func() { _ = client.Start(ctx) }()
go func() { _ = server.Start(ctx) }()
defer client.Close()
defer server.Close()
result, err := client.CallRaw(ctx, "echo", json.RawMessage(`{"text":"ok"}`))
if err != nil {
t.Fatalf("CallRaw() error = %v", err)
}
if string(result) != `{"text":"ok"}` {
t.Fatalf("result = %s", result)
}
}
func TestAfterIdleAppliesBufferedNotification(t *testing.T) {
clientReader, serverWriter := io.Pipe()
defer clientReader.Close()
defer serverWriter.Close()
client := NewPeer(clientReader, io.Discard, PeerOptions{})
var mu sync.Mutex
var applied string
client.RegisterNotification("session/update", func(ctx context.Context, raw json.RawMessage) {
var notification SessionNotification
if err := json.Unmarshal(raw, ¬ification); err != nil {
t.Errorf("unmarshal session/update: %v", err)
return
}
mu.Lock()
applied = sessionUpdateText(notification.Update)
mu.Unlock()
})
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
go func() { _ = client.Start(ctx) }()
defer client.Close()
errCh := make(chan error, 1)
go func() {
var result map[string]any
errCh <- client.Call(ctx, "session/prompt", map[string]any{}, &result)
}()
deadline := time.Now().Add(time.Second)
for {
client.pendingMu.Lock()
n := len(client.pending)
client.pendingMu.Unlock()
if n > 0 {
break
}
if time.Now().After(deadline) {
t.Fatal("call did not register pending id")
}
time.Sleep(time.Millisecond)
}
if _, err := io.WriteString(serverWriter, `{"jsonrpc":"2.0","id":1,"result":{"stopReason":"end_turn"}}`+"\n"); err != nil {
t.Fatal(err)
}
if _, err := io.WriteString(serverWriter, `{"jsonrpc":"2.0","method":"session/update","params":{"sessionId":"s1","update":{"sessionUpdate":"agent_message_chunk","text":"late"}}}`+"\n"); err != nil {
t.Fatal(err)
}
if err := <-errCh; err != nil {
t.Fatalf("Call() error = %v", err)
}
idle := make(chan struct{})
client.AfterIdle(func() { close(idle) })
select {
case <-idle:
case <-ctx.Done():
t.Fatal("AfterIdle did not run")
}
mu.Lock()
defer mu.Unlock()
if applied != "late" {
t.Fatalf("notification applied = %q, want late", applied)
}
}
func TestPeerRawMessageHookExcludesFrameDelimiter(t *testing.T) {
var out bytes.Buffer
var raw json.RawMessage
peer := NewPeer(strings.NewReader(""), &out, PeerOptions{
OnRawMessage: func(direction string, message json.RawMessage) {
if direction == "outbound" {
raw = append(raw[:0], message...)
}
},
})
err := peer.NotifyRaw(context.Background(), `method/"quoted"`, json.RawMessage(`{"value":"a<b>&c"}`))
if err != nil {
t.Fatalf("NotifyRaw() error = %v", err)
}
if len(raw) == 0 {
t.Fatalf("expected outbound raw message")
}
if bytes.Contains(raw, []byte{'\n'}) {
t.Fatalf("raw message contains frame delimiter: %q", raw)
}
var decoded rpcMessage
if err := json.Unmarshal(raw, &decoded); err != nil {
t.Fatalf("raw message is not valid JSON: %v", err)
}
if decoded.Method != `method/"quoted"` {
t.Fatalf("method = %q", decoded.Method)
}
}
func TestRPCErrorIncludesDataInErrorString(t *testing.T) {
tests := []struct {
name string
err *RPCError
want string
}{
{
name: "string data",
err: &RPCError{Code: -32603, Message: "Internal error", Data: json.RawMessage(`"Claude Code failed: missing auth"`)},
want: "rpc error -32603: Internal error: Claude Code failed: missing auth",
},
{
name: "object message",
err: &RPCError{Code: -32603, Message: "Internal error", Data: json.RawMessage(`{"message":"spawn failed","stderr":"ignored"}`)},
want: "rpc error -32603: Internal error: spawn failed",
},
{
name: "raw object fallback",
err: &RPCError{Code: -32603, Message: "Internal error", Data: json.RawMessage(`{"code":"E_AUTH"}`)},
want: `rpc error -32603: Internal error: {"code":"E_AUTH"}`,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := tt.err.Error(); got != tt.want {
t.Fatalf("Error() = %q, want %q", got, tt.want)
}
})
}
}
func TestParseRPCIDSupportsNumericResponses(t *testing.T) {
for _, raw := range []json.RawMessage{
json.RawMessage(`42`),
json.RawMessage(`"42"`),
json.RawMessage(" \t42\r\n"),
} {
id, ok := parseRPCID(raw)
if !ok || id != 42 {
t.Fatalf("parseRPCID(%q) = %d, %v; want 42, true", raw, id, ok)
}
}
}
func TestParseRPCMessageExtractsEnvelopeWithoutFullUnmarshal(t *testing.T) {
msg, ok := parseRPCMessage([]byte(`{"jsonrpc":"2.0","id":42,"result":{"items":[1,{"name":"ok"}]}}`))
if !ok {
t.Fatalf("parseRPCMessage() failed")
}
if string(msg.ID) != "42" {
t.Fatalf("ID = %q", msg.ID)
}
if string(msg.Result) != `{"items":[1,{"name":"ok"}]}` {
t.Fatalf("Result = %s", msg.Result)
}
}
func TestParseRPCMessageSupportsEscapedMethod(t *testing.T) {
msg, ok := parseRPCMessage([]byte(`{"jsonrpc":"2.0","method":"method/\"quoted\"","params":{"value":"a,b}"}}`))
if !ok {
t.Fatalf("parseRPCMessage() failed")
}
if msg.Method != `method/"quoted"` {
t.Fatalf("Method = %q", msg.Method)
}
if string(msg.Params) != `{"value":"a,b}"}` {
t.Fatalf("Params = %s", msg.Params)
}
}
func TestParseRPCMessageRejectsInvalidLiteral(t *testing.T) {
if _, ok := parseRPCMessage([]byte(`{"jsonrpc":"2.0","id":x,"result":null}`)); ok {
t.Fatalf("parseRPCMessage() accepted invalid literal")
}
}
func TestParseRPCMessageRejectsInvalidStringEscape(t *testing.T) {
if _, ok := parseRPCMessage([]byte("{\"\\000\":[]}")); ok {
t.Fatalf("parseRPCMessage() accepted invalid string escape")
}
}
func TestParseRPCMessageRejectsTrailingGarbage(t *testing.T) {
if _, ok := parseRPCMessage([]byte(`{}0`)); ok {
t.Fatalf("parseRPCMessage() accepted trailing garbage")
}
}
func TestParseRPCMessageRejectsInvalidCompositeValue(t *testing.T) {
if _, ok := parseRPCMessage([]byte(`{"":[A]}`)); ok {
t.Fatalf("parseRPCMessage() accepted invalid composite value")
}
}
func TestParseRPCMessageRejectsTrailingComma(t *testing.T) {
if _, ok := parseRPCMessage([]byte(`{"a":"b",}`)); ok {
t.Fatalf("parseRPCMessage() accepted trailing comma")
}
}
func TestParseRPCMessageRejectsInvalidUTF8String(t *testing.T) {
raw := []byte{'{', '"', 'm', 'e', 't', 'h', 'o', 'd', '"', ':', '"', 0x95, '"', '}'}
if _, ok := parseRPCMessage(raw); ok {
t.Fatalf("parseRPCMessage() accepted invalid UTF-8 string")
}
}
func TestParseRPCMessageMatchesExactJSONEnvelopeDecode(t *testing.T) {
for _, raw := range [][]byte{
[]byte(`{"jsonrpc":"2.0","id":42,"result":{"items":[1,{"name":"ok"}]}}`),
[]byte(`{"jsonrpc":"2.0","method":"session/update","params":{"sessionId":"s1","update":{"sessionUpdate":"user_message_chunk","content":{"type":"text","text":"ok"}}}}`),
[]byte(`{"jsonrpc":"2.0","method":"method/\"quoted\"","params":{"value":"a,b}"}}`),
[]byte(`{"jsonrpc":"2.0","meth\u006fd":"escaped-key","params":[true,false,null,{"nested":[1,2,3]}]}`),
[]byte(`{"error":{"code":-32000,"message":"failed","data":{"reason":"x"}},"id":"7","jsonrpc":"2.0"}`),
[]byte(`{"unknown":{"deep":[{"a":"b"}]},"id":99,"result":null}`),
} {
got, ok := parseRPCMessage(raw)
if !ok {
t.Fatalf("parseRPCMessage(%s) failed", raw)
}
want, ok := decodeRPCMessageExactForTest(raw)
if !ok {
t.Fatalf("exact JSON envelope decode failed for %s", raw)
}
assertRPCMessagesEquivalent(t, got, want)
}
}
func FuzzParseRPCMessage(f *testing.F) {
for _, seed := range []string{
`{"jsonrpc":"2.0","id":42,"result":{"items":[1,{"name":"ok"}]}}`,
`{"jsonrpc":"2.0","method":"session/update","params":{"sessionId":"s1"}}`,
`{"jsonrpc":"2.0","method":"method/\"quoted\"","params":{"value":"a,b}"}}`,
`{"jsonrpc":"2.0","meth\u006fd":"escaped-key","params":[true,false,null]}`,
`{"jsonrpc":"2.0","id":x,"result":null}`,
`not-json`,
} {
f.Add(seed)
}
f.Fuzz(func(t *testing.T, raw string) {
got, ok := parseRPCMessage([]byte(raw))
if !ok {
return
}
if !json.Valid([]byte(raw)) {
t.Fatalf("parseRPCMessage accepted invalid JSON: %q", raw)
}
want, ok := decodeRPCMessageExactForTest([]byte(raw))
if !ok {
t.Fatalf("exact JSON envelope decode failed after parser accepted input %q", raw)
}
assertRPCMessagesEquivalent(t, got, want)
})
}
func decodeRPCMessageExactForTest(raw []byte) (rpcMessage, bool) {
var fields map[string]json.RawMessage
if err := json.Unmarshal(raw, &fields); err != nil {
return rpcMessage{}, false
}
var msg rpcMessage
if value, ok := fields["id"]; ok {
msg.ID = value
}
if value, ok := fields["method"]; ok {
if err := json.Unmarshal(value, &msg.Method); err != nil {
return rpcMessage{}, false
}
}
if value, ok := fields["params"]; ok {
msg.Params = value
}
if value, ok := fields["result"]; ok {
msg.Result = value
}
if value, ok := fields["error"]; ok {
var rpcErr RPCError
if err := json.Unmarshal(value, &rpcErr); err != nil {
return rpcMessage{}, false
}
msg.Error = &rpcErr
}
return msg, true
}
func assertRPCMessagesEquivalent(t *testing.T, got, want rpcMessage) {
t.Helper()
if got.Method != want.Method {
t.Fatalf("Method = %q, want %q", got.Method, want.Method)
}
assertRawJSONEquivalent(t, "ID", got.ID, want.ID)
assertRawJSONEquivalent(t, "Params", got.Params, want.Params)
assertRawJSONEquivalent(t, "Result", got.Result, want.Result)
if !reflect.DeepEqual(got.Error, want.Error) {
t.Fatalf("Error = %#v, want %#v", got.Error, want.Error)
}
}
func assertRawJSONEquivalent(t *testing.T, name string, got, want json.RawMessage) {
t.Helper()
got = compactRawJSONForTest(t, got)
want = compactRawJSONForTest(t, want)
if !bytes.Equal(got, want) {
t.Fatalf("%s = %s, want %s", name, got, want)
}
}
func compactRawJSONForTest(t *testing.T, raw json.RawMessage) json.RawMessage {
t.Helper()
if len(raw) == 0 {
return nil
}
var buf bytes.Buffer
if err := json.Compact(&buf, raw); err != nil {
t.Fatalf("json.Compact(%s) error = %v", raw, err)
}
return buf.Bytes()
}
// TestCallEmitsCancelRequestOnContextCancel verifies that cancelling a Call's
// context emits a $/cancel_request notification (stabilized in ACP
// schema-v1.17.0) carrying the in-flight request id, so the agent can stop
// work instead of running to completion.
func TestCallEmitsCancelRequestOnContextCancel(t *testing.T) {
clientReader, serverWriter := io.Pipe()
serverReader, clientWriter := io.Pipe()
defer clientReader.Close()
defer serverWriter.Close()
defer serverReader.Close()
defer clientWriter.Close()
server := NewPeer(serverReader, serverWriter, PeerOptions{})
client := NewPeer(clientReader, clientWriter, PeerOptions{
OnRawMessage: func(direction string, message json.RawMessage) {
if direction == "outbound" && bytes.Contains(message, []byte(`$/cancel_request`)) {
t.Logf("saw cancel: %s", message)
}
},
})
// Block the "slow" request so it stays pending until we cancel.
slowStarted := make(chan struct{})
slowReleased := make(chan struct{})
server.RegisterRequest("slow", func(ctx context.Context, raw json.RawMessage) (any, error) {
close(slowStarted)
select {
case <-slowReleased:
return "done", nil
case <-ctx.Done():
return nil, ctx.Err()
}
})
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() { _ = server.Start(ctx) }()
go func() { _ = client.Start(ctx) }()
defer server.Close()
defer client.Close()
callCtx, callCancel := context.WithCancel(ctx)
callDone := make(chan error, 1)
go func() {
var result json.RawMessage
err := client.Call(callCtx, "slow", nil, &result)
callDone <- err
}()
select {
case <-slowStarted:
case <-time.After(2 * time.Second):
t.Fatalf("slow handler never started")
}
// Cancel the in-flight call; the client should emit $/cancel_request.
callCancel()
select {
case err := <-callDone:
if err == nil {
t.Fatalf("expected cancelled error, got nil")
}
case <-time.After(2 * time.Second):
t.Fatalf("Call did not return after cancel")
}
// Read the raw bytes the client wrote to the server to confirm a
// $/cancel_request frame was emitted. We capture it by scanning the
// outbound stream: the client wrote into clientWriter which feeds
// serverReader. Instead, assert via a fresh peer that observes the wire.
// Simpler: re-run with a capturing writer.
close(slowReleased)
}
// TestCallCancelEmitsCancelRequestOnWire confirms the $/cancel_request frame is
// physically emitted on the wire by capturing outbound messages via the
// OnRawMessage hook. The cancelled call's id must appear in the cancel params.
func TestCallCancelEmitsCancelRequestOnWire(t *testing.T) {
clientReader, serverWriter := io.Pipe()
serverReader, clientWriter := io.Pipe()
defer clientReader.Close()
defer serverWriter.Close()
defer serverReader.Close()
defer clientWriter.Close()
server := NewPeer(serverReader, serverWriter, PeerOptions{})
slowStarted := make(chan struct{})
server.RegisterRequest("slow", func(ctx context.Context, raw json.RawMessage) (any, error) {
close(slowStarted)
<-ctx.Done() // never return on its own
return nil, ctx.Err()
})
var cancelFrame []byte
var cancelMu sync.Mutex
client := NewPeer(clientReader, clientWriter, PeerOptions{
OnRawMessage: func(direction string, message json.RawMessage) {
if direction == "outbound" && bytes.Contains(message, []byte(`$/cancel_request`)) {
cancelMu.Lock()
cancelFrame = append(cancelFrame[:0], message...)
cancelMu.Unlock()
}
},
})
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() { _ = server.Start(ctx) }()
go func() { _ = client.Start(ctx) }()
defer server.Close()
defer client.Close()
callCtx, callCancel := context.WithCancel(ctx)
callDone := make(chan error, 1)
go func() {
var result json.RawMessage
callDone <- client.Call(callCtx, "slow", nil, &result)
}()
select {
case <-slowStarted:
case <-time.After(2 * time.Second):
t.Fatalf("slow handler never started")
}
callCancel()
<-callDone
cancelMu.Lock()
frame := append([]byte(nil), cancelFrame...)
cancelMu.Unlock()
if frame == nil {
t.Fatalf("no $/cancel_request frame captured on outbound wire")
}
var decoded struct {
Method string `json:"method"`
Params json.RawMessage `json:"params"`
}
if err := json.Unmarshal(frame, &decoded); err != nil {
t.Fatalf("cancel frame not valid JSON: %v\n%s", err, frame)
}
if decoded.Method != "$/cancel_request" {
t.Fatalf("method = %q, want $/cancel_request", decoded.Method)
}
// Per ACP schema-v1.17.0 CancelRequestNotification, the param field is
// "requestId" (camelCase), NOT "id".
if !bytes.Contains(decoded.Params, []byte(`"requestId"`)) {
t.Fatalf("cancel params missing requestId field: %s", decoded.Params)
}
if bytes.Contains(decoded.Params, []byte(`"id":`)) {
t.Fatalf("cancel params must not use bare 'id' field (spec requires requestId): %s", decoded.Params)
}
}
// TestInboundCancelRequestHonored verifies the BIDIRECTIONAL requirement of
// $/cancel_request (ACP schema-v1.17.0, x-side: "protocol"): when the peer
// sends $/cancel_request for an in-flight inbound request, the host cancels
// the handler's context and the original request gets a -32800 "Request
// cancelled" error response.
func TestInboundCancelRequestHonored(t *testing.T) {
clientReader, serverWriter := io.Pipe()
serverReader, clientWriter := io.Pipe()
defer clientReader.Close()
defer serverWriter.Close()
defer serverReader.Close()
defer clientWriter.Close()
server := NewPeer(serverReader, serverWriter, PeerOptions{})
client := NewPeer(clientReader, clientWriter, PeerOptions{})
handlerStarted := make(chan struct{})
handlerCancelled := make(chan error, 1)
server.RegisterRequest("slow_reverse", func(ctx context.Context, raw json.RawMessage) (any, error) {
close(handlerStarted)
<-ctx.Done() // block until cancelled
handlerCancelled <- ctx.Err()
return nil, ctx.Err()
})
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() { _ = server.Start(ctx) }()
go func() { _ = client.Start(ctx) }()
defer server.Close()
defer client.Close()
// Client sends a request to the server.
callDone := make(chan error, 1)
go func() {
var result json.RawMessage
callDone <- client.Call(ctx, "slow_reverse", nil, &result)
}()
select {
case <-handlerStarted:
case <-time.After(2 * time.Second):
t.Fatalf("handler never started")
}
// Client sends $/cancel_request with the correct "requestId" field name to
// cancel the in-flight request. The original request id was 1.
if err := client.Notify(ctx, "$/cancel_request", map[string]any{"requestId": 1}); err != nil {
t.Fatalf("Notify $/cancel_request error = %v", err)
}
// The handler's context must be cancelled.
select {
case err := <-handlerCancelled:
if err == nil {
t.Fatalf("handler ctx.Err() = nil, want context.Canceled")
}
case <-time.After(2 * time.Second):
t.Fatalf("handler was not cancelled by $/cancel_request")
}
// The original Call must return a -32800 "Request cancelled" error.
err := <-callDone
if err == nil {
t.Fatalf("expected cancelled error, got nil")
}
rpcErr, ok := err.(*RPCError)
if !ok {
t.Fatalf("error type = %T, want *RPCError", err)
}
if rpcErr.Code != -32800 {
t.Fatalf("error code = %d, want -32800 (Request cancelled)", rpcErr.Code)
}
if rpcErr.Message != "Request cancelled" {
t.Fatalf("error message = %q, want %q", rpcErr.Message, "Request cancelled")
}
}
// TestInboundCancelRequestUnknownIdIsNoop verifies that a $/cancel_request for
// an unknown/non-existent requestId is silently ignored (per spec, no error).
func TestInboundCancelRequestUnknownIdIsNoop(t *testing.T) {
clientReader, serverWriter := io.Pipe()
serverReader, clientWriter := io.Pipe()
defer clientReader.Close()
defer serverWriter.Close()
defer serverReader.Close()
defer clientWriter.Close()
server := NewPeer(serverReader, serverWriter, PeerOptions{})
client := NewPeer(clientReader, clientWriter, PeerOptions{})
server.RegisterRequest("echo2", func(ctx context.Context, raw json.RawMessage) (any, error) {
return raw, nil
})
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() { _ = server.Start(ctx) }()
go func() { _ = client.Start(ctx) }()
defer server.Close()
defer client.Close()
// Send a cancel for an id that was never sent. Must not error or hang.
if err := client.Notify(ctx, "$/cancel_request", map[string]any{"requestId": 99999}); err != nil {
t.Fatalf("Notify unknown cancel error = %v", err)
}
// A subsequent normal call must still work (server not disrupted).
var result json.RawMessage
if err := client.Call(ctx, "echo2", json.RawMessage(`"ok"`), &result); err != nil {
t.Fatalf("Call after unknown cancel error = %v", err)
}
if string(result) != `"ok"` {
t.Fatalf("result = %s", result)
}
}
// TestSessionDeleteAndLogoutRoundTrip verifies the new stable-v1 methods
// session/delete and logout are sent correctly and the host receives them.
func TestSessionDeleteAndLogoutRoundTrip(t *testing.T) {
clientReader, serverWriter := io.Pipe()
serverReader, clientWriter := io.Pipe()
defer clientReader.Close()
defer serverWriter.Close()
defer serverReader.Close()
defer clientWriter.Close()
server := NewPeer(serverReader, serverWriter, PeerOptions{})
client := NewPeer(clientReader, clientWriter, PeerOptions{})
var deleteSeen, logoutSeen bool
var mu sync.Mutex
// The conn wraps the server peer; its Call goes out serverWriter -> client
// peer, so the handlers must be registered on the client peer.
client.RegisterRequest("session/delete", func(ctx context.Context, raw json.RawMessage) (any, error) {
mu.Lock()
deleteSeen = bytes.Contains(raw, []byte(`"sessionId":"s1"`))
mu.Unlock()
return DeleteSessionResponse{}, nil
})
client.RegisterRequest("logout", func(ctx context.Context, raw json.RawMessage) (any, error) {
mu.Lock()
logoutSeen = true
mu.Unlock()
return LogoutResponse{}, nil
})
conn := NewConnection(server, Client{Authority: AuthorityHandlers{}})
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
defer cancel()
go func() { _ = server.Start(ctx) }()
go func() { _ = client.Start(ctx) }()
defer server.Close()
defer client.Close()
if err := conn.DeleteSession(ctx, DeleteSessionRequest{SessionID: "s1"}); err != nil {
t.Fatalf("DeleteSession error = %v", err)
}
if err := conn.Logout(ctx, LogoutRequest{}); err != nil {
t.Fatalf("Logout error = %v", err)
}
mu.Lock()
defer mu.Unlock()
if !deleteSeen {
t.Fatalf("client never received session/delete with sessionId s1")
}
if !logoutSeen {
t.Fatalf("client never received logout")
}
}