CI is skipping tests even when source code changes

[smol-ninja]

As can be seen in:

1. https://github.com/sablier-labs/airdrops/actions/runs/14774431107
2. https://github.com/sablier-labs/airdrops/actions/runs/14774620558.

Any tip @PaulRBerg how to debug it?

[smol-ninja]

Though it worked in sablier-labs/airdrops#153.

[PaulRBerg]

Add echo statements in a new branch in this repo and install that branch

If there has been any change in the Solidity files, that should have triggered an update in the cache, so it's strange

gha-utils/.github/actions/evm-cache/action.yml

Line 32 in d9773d5

forge-build-${{ hashFiles('bun.lock') }}-${{ hashFiles('foundry.toml') }}-${{ hashFiles('**/*.sol') }}

[smol-ninja]

If there has been any change in the Solidity files

Oh yes, tons of changes.

Add echo statements in a new branch in this repo and install that branch

OK will try tomorrow.

[PaulRBerg]

I have a guess that what happened is this:

The cache action looked at the diff between commits on that PR branch

One of those chore: commits might not have changed anything in Solidity.

I wonder if we should allow users to pass a git ref as an input to use for comparison in the cache action?

Or, more simply, to allow users to always override the cache

[smol-ninja]

This is what happened.

It didn't run the tests on the docs commit because the lint failed (lint is a requirement for test jobs) but it updated the cache (because lint is not the requirement to build contracts). So on the next commit, the revert commit didn't make any change to the code, and therefore it skipped the tests.

It worked as expected. The caveat is that if the CI fails due to linting error (with a successful build), it will not run the tests on the next commit if it does not contain solidity changes.

So, the solution is to run tests even if the lint job fails. i.e. remove lint requirement from all tests. We should allow test jobs to run even when lint fails, similar to build.

[smol-ninja]

Fixed in sablier-labs/airdrops@0db4fdf

I think thats the solution to this problem. We can close this issue if you agree.

[PaulRBerg]

Alternatively, we could run build only if lint passes? But that would increase CI time.

So I guess your solution is better.