-
Notifications
You must be signed in to change notification settings - Fork 6
refactor: convert Store namespace exports to object exports #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: convert Store namespace exports to object exports #275
Conversation
Replace namespace pattern with plain object exports to enable proper
type inference for Biome's noFloatingPromises lint rule.
Before: export namespace Store { export import Entity = ... }
After: export const Store = { Entity: ... }
This fixes a linting blind spot where async Store method calls without
await were not being detected, preventing bugs like the one in
envio/airdrops/mappings/common/campaign/transfer-admin.ts:37.
WalkthroughFour Store index files across the envio package are refactored to replace exported namespaces with exported constant objects. The files modified are envio/airdrops/store/index.ts, envio/common/store/index.ts, envio/flow/store/index.ts, and envio/lockup/store/index.ts. Each change converts re-exported namespace members using the Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used📓 Path-based instructions (1)**/*.{js,ts,tsx,jsx,json,css,graphql}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-11-27T11:27:47.428ZApplied to files:
🧬 Code graph analysis (3)envio/flow/store/index.ts (2)
envio/airdrops/store/index.ts (2)
envio/lockup/store/index.ts (2)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replace namespace pattern with plain object exports to enable proper type inference for Biome's noFloatingPromises lint rule.
Before:
export namespace Store { export import Entity = ... }After:
export const Store = { Entity: ... }This fixes a linting blind spot where async Store method calls without await were not being detected, preventing bugs like the one in
envio/airdrops/mappings/common/campaign/transfer-admin.ts:37this fixes #252