Returning 404 if a subnode of a non-collection is accessed.

Fixes Issue 46.

Author: evert

ChangeLog

@@ -1,4 +1,5 @@
 1.2.0beta2 (2010-05-??)
+	* Fixed: Issue 46: Fatal error for some non-existant nodes.
 	* Updated: some example sql to include email address.
 	* Added: 208 and 508 statuscodes from RFC5842.
 	* Added: Apache2 configuration examples

lib/Sabre/DAV/ObjectTree.php

@@ -54,6 +54,9 @@ public function getNodeForPath($path) {
             // If this part of the path is just a dot, it actually means we can skip it
             if ($pathPart=='.' || $pathPart=='') continue;
 
+            if (!($currentNode instanceof Sabre_DAV_ICollection))
+                throw new Sabre_DAV_Exception_FileNotFound('Could not find node at path: ' . $path);
+
             $currentNode = $currentNode->getChild($pathPart); 
 
         }

tests/Sabre/DAV/ServerSimpleTest.php

@@ -44,6 +44,20 @@ function testGetDoesntExist() {
 
     }
 
+    function testGetDoesntExist2() {
+       
+        $serverVars = array(
+            'REQUEST_URI'    => '/test.txt/randomblbla',
+            'REQUEST_METHOD' => 'GET',
+        );
+
+        $request = new Sabre_HTTP_Request($serverVars);
+        $this->server->httpRequest = ($request);
+        $this->server->exec();
+        $this->assertEquals('HTTP/1.1 404 Not Found',$this->response->status);
+
+    }
+
     /**
      * This test should have the exact same result as testGet.
      *