Throwing 501 for HEAD on non-files

Update issue #19
Fixed issue on trunk

Author: evert

lib/Sabre/DAV/Server.php

@@ -370,7 +370,10 @@ protected function httpGet() {
     protected function httpHead() {
 
         $node = $this->tree->getNodeForPath($this->getRequestUri());
-        if ($node instanceof Sabre_DAV_IFile && $size = $node->getSize())
+
+        if (!($node instanceof Sabre_DAV_IFile)) throw new Sabre_DAV_Exception_NotImplemented('HEAD is only implemented on File objects');
+
+        if ($size = $node->getSize())
             $this->httpResponse->setHeader('Content-Length',$size);
 
         if ($etag = $node->getETag()) {

tests/Sabre/DAV/ServerSimpleTest.php

@@ -298,6 +298,44 @@ function testNonExistantMethod() {
 
     }
 
+    function testGETOnCollection() {
+
+        $serverVars = array(
+            'REQUEST_URI'    => '/',
+            'REQUEST_METHOD' => 'GET',
+        );
+
+        $request = new Sabre_HTTP_Request($serverVars);
+        $this->server->httpRequest = ($request);
+        $this->server->exec();
+
+        $this->assertEquals(array(
+            'Content-Type' => 'application/xml; charset=utf-8',
+        ),$this->response->headers);
+
+        $this->assertEquals('HTTP/1.1 501 Not Implemented',$this->response->status);
+
+    }
+
+    function testHEADOnCollection() {
+
+        $serverVars = array(
+            'REQUEST_URI'    => '/',
+            'REQUEST_METHOD' => 'HEAD',
+        );
+
+        $request = new Sabre_HTTP_Request($serverVars);
+        $this->server->httpRequest = ($request);
+        $this->server->exec();
+
+        $this->assertEquals(array(
+            'Content-Type' => 'application/xml; charset=utf-8',
+        ),$this->response->headers);
+
+        $this->assertEquals('HTTP/1.1 501 Not Implemented',$this->response->status);
+
+    }
+
     function testBaseUri() {
 
         $serverVars = array(