Added a bunch of tests. Increasing the coverage a bit.

Author: evert

examples/calendarserver.php

@@ -68,6 +68,10 @@ function exception_error_handler($errno, $errstr, $errfile, $errline) {
 /* WebDAV-Sync plugin */
 $server->addPlugin(new Sabre\DAV\Sync\Plugin());
 
+/* CalDAV Sharing support */
+$server->addPlugin(new Sabre\DAV\Sharing\Plugin());
+$server->addPlugin(new Sabre\CalDAV\SharingPlugin());
+
 // Support for html frontend
 $browser = new Sabre\DAV\Browser\Plugin();
 $server->addPlugin($browser);

lib/CalDAV/Backend/PDO.php

@@ -1502,7 +1502,7 @@ function getInvites($calendarId) {
      */
     function setPublishStatus($calendarId, $value) {
 
-        throw new \Exception('Not implemented');
+        throw new \Sabre\DAV\Exception\NotImplemented('Not implemented');
 
     }
 

lib/CalDAV/Xml/Property/ScheduleCalendarTransp.php

@@ -4,8 +4,8 @@
 
 use Sabre\Xml\Element;
 use Sabre\Xml\Reader;
+use Sabre\Xml\Deserializer;
 use Sabre\Xml\Writer;
-use Sabre\Xml\Element\Elements;
 use Sabre\CalDAV\Plugin;
 
 /**
@@ -116,23 +116,13 @@ function xmlSerialize(Writer $writer) {
      */
     static function xmlDeserialize(Reader $reader) {
 
-        $elems = Elements::xmlDeserialize($reader);
+        $elems = Deserializer\enum($reader, Plugin::NS_CALDAV);
 
-        $value = null;
-
-        foreach ($elems as $elem) {
-            switch ($elem) {
-                case '{' . Plugin::NS_CALDAV . '}opaque' :
-                    $value = self::OPAQUE;
-                    break;
-                case '{' . Plugin::NS_CALDAV . '}transparent' :
-                    $value = self::TRANSPARENT;
-                    break;
-            }
+        if (in_array('transparent', $elems)) {
+            $value = self::TRANSPARENT;
+        } else {
+            $value = self::OPAQUE;
         }
-        if (is_null($value))
-           return null;
-
         return new self($value);
 
     }

lib/DAV/Auth/Backend/File.php

@@ -25,7 +25,7 @@ class File extends AbstractDigest {
     /**
      * Creates the backend object.
      *
-     * If the filename argument is passed in, it will parse out the specified file fist.
+     * If the filename argument is passed in, it will parse out the specified file first.
      *
      * @param string|null $filename
      */

lib/DAV/FSExt/Directory.php

@@ -131,12 +131,7 @@ function getChildren() {
 
         foreach ($iterator as $entry) {
 
-            $node = $entry->getFilename();
-
-            if ($node === '.sabredav')
-                continue;
-
-            $nodes[] = $this->getChild($node);
+            $nodes[] = $this->getChild($entry->getFilename());
 
         }
         return $nodes;
@@ -153,9 +148,6 @@ function delete() {
         // Deleting all children
         foreach ($this->getChildren() as $child) $child->delete();
 
-        // Removing resource info, if its still around
-        if (file_exists($this->path . '/.sabredav')) unlink($this->path . '/.sabredav');
-
         // Removing the directory itself
         rmdir($this->path);
 

lib/DAV/Xml/Property/ShareAccess.php

@@ -127,7 +127,7 @@ static function xmlDeserialize(Reader $reader) {
             switch ($elem['name']) {
                 case '{DAV:}not-shared' :
                     return new self(SharingPlugin::ACCESS_NOTSHARED);
-                case '{DAV:}sharedowner' :
+                case '{DAV:}shared-owner' :
                     return new self(SharingPlugin::ACCESS_SHAREDOWNER);
                 case '{DAV:}read' :
                     return new self(SharingPlugin::ACCESS_READ);

lib/DAV/Xml/Property/SupportedMethodSet.php

@@ -32,16 +32,11 @@ class SupportedMethodSet implements XmlSerializable, HtmlOutput {
     /**
      * Creates the property
      *
-     * Any reports passed in the constructor
-     * should be valid report-types in clark-notation.
-     *
-     * Either a string or an array of strings must be passed.
-     *
-     * @param string|string[] $methods
+     * @param string[] $methods
      */
-    function __construct($methods = null) {
+    function __construct(array $methods) {
 
-        $this->methods = (array)$methods;
+        $this->methods = $methods;
 
     }
 

tests/Sabre/CalDAV/Backend/AbstractPDOTest.php

@@ -1418,4 +1418,14 @@ function testDeleteSharedCalendar() {
 
     }
 
+    /**
+     * @expectedException \Sabre\DAV\Exception\NotImplemented
+     */
+    function testSetPublishStatus() {
+
+        $backend = new PDO($this->pdo);
+        $backend->setPublishStatus([1, 1], true);
+
+    }
+
 }

tests/Sabre/CalDAV/Xml/Property/InviteTest.php

@@ -19,8 +19,9 @@ function setUp() {
 
     function testSimple() {
 
-        $sccs = new Invite([]);
-        $this->assertInstanceOf('Sabre\CalDAV\Xml\Property\Invite', $sccs);
+        $invite = new Invite([]);
+        $this->assertInstanceOf('Sabre\CalDAV\Xml\Property\Invite', $invite);
+        $this->assertEquals([], $invite->getValue());
 
     }
 

tests/Sabre/DAV/Auth/Backend/FileTest.php

@@ -23,8 +23,7 @@ function testConstruct() {
     function testLoadFileBroken() {
 
         file_put_contents(SABRE_TEMPDIR . '/backend', 'user:realm:hash');
-        $file = new File();
-        $file->loadFile(SABRE_TEMPDIR . '/backend');
+        $file = new File(SABRE_TEMPDIR . '/backend');
 
     }