CardDAV addressbook-multiget report does not create href urls correctly from the xml request body

[shubhra-prakash-nandi]

If I send the below addressbook-multiget report request to a differently formed (notice // after hostname) URL - http://hostname//addressbooks/principal/something/ the hrefs in the request are not formed correctly. They are formed something like //addressbooks/addressbooks/principal/something/uri1.vcf

<card:addressbook-multiget xmlns:d="DAV:" xmlns:card="urn:ietf:params:xml:ns:carddav">
    <d:prop>
        <d:getetag />
        <card:address-data />
    </d:prop>
    <d:href>/addressbooks/principal/something/uri1.vcf</d:href>
    <d:href>/addressbooks/principal/something/uri2.vcf</d:href>
</card:addressbook-multiget>

I am providing the patch for this below. Please check and incorporate as needed.

--- commit-bc0b0ada27a3653e9955381abd6f1334b874dc06/lib/CardDAV/Xml/Request/AddressBookMultiGetReport.php	2026-03-18 15:46:22.186973946 +0530
+++ patch/lib/CardDAV/Xml/Request/AddressBookMultiGetReport.php	2026-03-18 15:50:46.019104219 +0530
@@ -101,7 +101,7 @@
                     }
                     break;
                 case '{DAV:}href':
-                    $newProps['hrefs'][] = Uri\resolve($reader->contextUri, $elem['value']);
+                    $newProps['hrefs'][] = Uri\resolve(preg_replace('|/+|', '/', $reader->contextUri), $elem['value']);
                     break;
             }
         }

[alecpl]

Thanks for the report, but there must be a better, more generic, fix for this problem.

[shubhra-prakash-nandi]

Hi, I think there are two parts to it, one in Plugin.php where $this->server->calculateUri() is being used to update hrefs in response and it is doing the same thing as the patch above but, for requests, only multiget report get hrefs from clients which need to be resolved. So I believe even though this patch is request specific this patch should be sufficient till we check in a generic fashion for each request if hrefs are present and resolve them like we do for responses in Plugin.php may be in a beforeMethod() ?