Skip to content

Commit 01d1edc

Browse files
authored
Merge pull request #788 from phil-davis/failOnDeprecation
chore: set failOnDeprecation in phpunit
2 parents 4ebce2b + 0ab3690 commit 01d1edc

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

‎lib/Component/VCard.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ public function xmlSerialize(Xml\Writer $writer): void
479479
$propertiesByGroup = [];
480480

481481
foreach ($this->children() as $property) {
482-
$group = $property->group;
482+
$group = $property->group ?? '';
483483

484484
$propertiesByGroup[$group] ??= [];
485485

‎tests/phpunit.xml‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,14 @@
11
<?xml version="1.0"?>
2-
<phpunit colors="true" bootstrap="bootstrap.php" beStrictAboutTestsThatDoNotTestAnything="true" beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true" enforceTimeLimit="true" cacheDirectory=".phpunit.cache">
2+
<phpunit colors="true"
3+
bootstrap="bootstrap.php"
4+
beStrictAboutTestsThatDoNotTestAnything="true"
5+
beStrictAboutOutputDuringTests="true"
6+
failOnRisky="true"
7+
failOnWarning="true"
8+
failOnDeprecation="true"
9+
enforceTimeLimit="true"
10+
cacheDirectory=".phpunit.cache"
11+
>
312
<php>
413
<ini name="error_reporting" value="E_ALL"/>
514
</php>

0 commit comments

Comments
 (0)