Merge pull request #523 from mstilkerich/fix_set_properties_with_groups

Fix setting properties with group assignment

Author: phil-davis

lib/Component.php

@@ -160,9 +160,9 @@ public function remove($item)
                     return;
                 }
             }
-        }
 
-        throw new \InvalidArgumentException('The item you passed to remove() was not a child of this component');
+            throw new \InvalidArgumentException('The item you passed to remove() was not a child of this component');
+        }
     }
 
     /**

tests/VObject/ComponentTest.php

@@ -72,6 +72,23 @@ public function testMagicGetGroups()
         $this->assertEquals(null, $email3[0]->group);
     }
 
+    public function testAddGroupProperties()
+    {
+        $comp = new VCard([
+            'VERSION' => '3.0',
+            'item2.X-ABLabel' => 'item2-Foo',
+        ]);
+
+        $comp->{'ITEM1.X-ABLabel'} = 'ITEM1-Foo';
+
+        foreach (['item2', 'ITEM1'] as $group) {
+            $prop = $comp->{"$group.X-ABLabel"};
+            $this->assertInstanceOf(Property::class, $prop);
+            $this->assertSame("$group-Foo", (string) $prop);
+            $this->assertSame($group, $prop->group);
+        }
+    }
+
     public function testMagicIsset()
     {
         $comp = new VCalendar();