updated import and dot env

Author: sadabnepal

.github/workflows/playwright.yml

@@ -1,7 +1,5 @@
 name: Playwright Tests
 on:
-  push:
-    branches: [ main ]
   pull_request:
     branches: [ main ]
 jobs:

.vscode/settings.json

@@ -1,5 +1,8 @@
 {
     "editor.formatOnSave": true,
+    "editor.codeActionsOnSave": {
+        "source.organizeImports": "always"
+    },
     "cSpell.words": [
         "Ortoni"
     ]

readme.md

@@ -41,9 +41,9 @@ check script section of package.json for more test commands
 
 
 TODO:
-- optimize reading env variables
 - add fixtures to optimize page imports
 - update readme file
+- optimize import path
 
 ## Sample Report:
 ![Ortoni-Report](./samples/ortoni-report.png)

tests/helper/env.ts

@@ -0,0 +1,9 @@
+import { config } from 'dotenv';
+import { resolve } from 'path';
+
+config({ path: resolve(process.cwd(), '.env') });
+
+export default class ENV {
+    public static readonly USERNAME = process.env.USERNAME as string;
+    public static readonly PASSWORD = process.env.PASSWORD as string;
+}

tests/specs/admin/admin.spec.ts

@@ -1,17 +1,15 @@
-import { test, expect } from 'playwright/test';
-import LandingPage from '../../pages/landing.page';
+import { expect, test } from 'playwright/test';
+import { userData } from '../../data/user';
+import ENV from '../../helper/env';
 import AdminPage from '../../pages/admin.page';
-import LoginPage from '../../pages/login.page';
 import { toastMessage } from '../../pages/component';
-import { userData } from '../../data/user';
-
-import { config } from 'dotenv';
-config({ path: '.env' });
+import LandingPage from '../../pages/landing.page';
+import LoginPage from '../../pages/login.page';
 
 test('validate admin page', async ({ page }) => {
     const loginPage = new LoginPage(page);
     await loginPage.open();
-    await loginPage.login(process.env.USERNAME as string, process.env.PASSWORD as string);
+    await loginPage.login(ENV.USERNAME, ENV.PASSWORD);
 
     const landingPage = new LandingPage(page);
     await expect(landingPage.pageHeader).toBeVisible();

tests/specs/employee/addEmployee.spec.ts

@@ -1,17 +1,15 @@
-import { test, expect } from 'playwright/test';
-import LandingPage from '../../pages/landing.page';
-import LoginPage from '../../pages/login.page';
-
-import { config } from 'dotenv';
+import { expect, test } from 'playwright/test';
+import { createEmployeeData } from '../../data/employee';
+import ENV from '../../helper/env';
 import { toastMessage } from '../../pages/component';
 import EmployeePage from '../../pages/employee.page';
-import { createEmployeeData } from '../../data/employee';
-config({ path: '.env' });
+import LandingPage from '../../pages/landing.page';
+import LoginPage from '../../pages/login.page';
 
 test('validate add employee', async ({ page }) => {
     const loginPage = new LoginPage(page);
     await loginPage.open();
-    await loginPage.login(process.env.USERNAME as string, process.env.PASSWORD as string);
+    await loginPage.login(ENV.USERNAME, ENV.PASSWORD);
 
     const landingPage = new LandingPage(page);
     await expect(landingPage.pageHeader).toBeVisible();

tests/specs/login/login.spec.ts

@@ -1,9 +1,7 @@
-import { test, expect } from '@playwright/test';
-import LoginPage from '../../pages/login.page';
+import { expect, test } from '@playwright/test';
+import ENV from '../../helper/env';
 import LandingPage from '../../pages/landing.page';
-
-import { config } from 'dotenv';
-config({ path: '.env' });
+import LoginPage from '../../pages/login.page';
 
 test.beforeEach('open app', async ({ page }) => {
     const loginPage = new LoginPage(page);
@@ -18,7 +16,7 @@ test('company footer link', async ({ page }) => {
 
 test('successful login', async ({ page }) => {
     const loginPage = new LoginPage(page);
-    await loginPage.login(process.env.USERNAME as string, process.env.PASSWORD as string);
+    await loginPage.login(ENV.USERNAME, ENV.PASSWORD);
 
     const landingPage = new LandingPage(page);
     await expect(landingPage.pageHeader).toBeVisible();