Skip to content

Commit d98539f

Browse files
committed
resolve #220
1 parent 0b44e13 commit d98539f

5 files changed

Lines changed: 30 additions & 21 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
- Bumped the package version to 1.7.0 across configuration files, and updated dependencies for `decoupler` and `cvxpy-base` to `>=1.7.0`.
1111
- Added Python 3.13 support in classifiers. #216
1212
- Added Installation instructions in `installation.md`. #217
13+
- Properly check if a passed (cell type) labels in plotting are a string #220
1314

1415
## 1.6.1 (28.09.2025)
1516

docs/notebooks/basic_usage.ipynb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,7 @@
494494
},
495495
{
496496
"cell_type": "markdown",
497+
"id": "804d2c01",
497498
"metadata": {},
498499
"source": [
499500
"## By default, LIANA+ uses **human gene symbols**. See the documentation and the [Prior Knowledge vignette](https://liana-py.readthedocs.io/en/latest/notebooks/prior_knowledge.html) for details and instructions for homology conversion.\n"

docs/notebooks/inflow_score.ipynb

Lines changed: 27 additions & 17 deletions
Large diffs are not rendered by default.

src/liana/method/sp/_compute_global_specificity.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ def _get_group_mean(X, groupby_labels, var_names, groups_order=None):
1515
s = pd.Series(groupby_labels)
1616
groups_dum = pd.get_dummies(s, dummy_na=False)
1717

18-
if groups_order is not None:
19-
groups_dum = groups_dum.reindex(columns=groups_order, fill_value=0)
20-
2118
t_sparse = csr_matrix(groups_dum)
2219
col_sums = np.asarray(t_sparse.sum(axis=0)).ravel()
2320
col_sums[col_sums == 0] = 1.0

src/liana/plotting/_common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ def _prep_liana_res(adata=None,
4848

4949
def _filter_labels(liana_res, labels, label_type):
5050
if labels is not None:
51-
if labels is str:
51+
if isinstance(labels, str):
5252
labels = [labels]
5353
covered = np.isin(labels, liana_res[label_type])
5454
if not covered.all():

0 commit comments

Comments
 (0)