chores: improve consitency of logging messages regardless the backend or downloader selected.

Author: ecarrenolozano

ontograph/client.py

@@ -376,7 +376,7 @@ def load(
             >>> client = ClientOntology()
             >>> client.load(source="./tests/resources/dummy_ontology.obo")
         """
-        logger.info(f'Loading ontology from source: {source} ...')
+        logger.info('Loading ontology: %s', source)
         resolved_downloader = (
             _resolve_downloader(self._cache_dir, downloader)
             if downloader is not None
@@ -397,15 +397,15 @@ def load(
 
         # 1. Case 1: Local file exists
         if path.exists():
-            logger.debug('Resolved source type: file')
+            logger.debug('Resolved source: %s -> file', source)
             logger.info(
                 f'Found local file at {path}, loading with ProntoLoaderAdapter...'
             )
             ontology = loader.load_from_file(file_path_ontology=path)
 
         # 2. Case 2: Provided source is a URL
         elif re.match(r'^https?://', source):
-            logger.debug('Resolved source type: url')
+            logger.debug('Resolved source: %s -> url', source)
             logger.info(
                 f'Detected URL source, downloading ontology from {source}'
             )
@@ -416,7 +416,7 @@ def load(
 
         # 3. Case 3: Try OBO catalog (if file missing or simple ID)
         else:
-            logger.debug('Resolved source type: catalog')
+            logger.debug('Resolved source: %s -> catalog', source)
             catalog_client = ClientCatalog(
                 cache_dir=self._cache_dir,
                 downloader=resolved_downloader,

ontograph/downloader.py

@@ -91,17 +91,23 @@ def get_default_downloader(
     from ontograph.config.settings import DEFAULT_DOWNLOADER
 
     selection = (backend or DEFAULT_DOWNLOADER).strip().lower()
-    logger.info('Selected default downloader backend: %s', selection)
+    logger.info(
+        'Downloader selected: %s (%s)',
+        selection,
+        'PoochDownloaderAdapter'
+        if selection == 'pooch'
+        else 'DownloadManagerAdapter',
+    )
     if selection == 'pooch':
         logger.debug(
-            'Instantiating downloader: %s (cache_dir=%s)',
+            'Downloader init: %s (cache_dir=%s)',
             PoochDownloaderAdapter.__name__,
             cache_dir,
         )
         return PoochDownloaderAdapter(cache_dir=cache_dir)
     if selection == 'download_manager':
         logger.debug(
-            'Instantiating downloader: %s (cache_dir=%s)',
+            'Downloader init: %s (cache_dir=%s)',
             DownloadManagerAdapter.__name__,
             cache_dir,
         )
@@ -156,17 +162,17 @@ def fetch_from_url(self, url_ontology: str, filename: str | None) -> Path:
         """
         self._validate_download_parameters(url_ontology, filename)
 
-        logger.info('Pooch download started: %s -> %s', url_ontology, filename)
+        logger.info('Download start: %s -> %s', url_ontology, filename)
         try:
             result_path = self._perform_download(url_ontology, filename)
             self._resources_paths[filename.split('.')[0]] = result_path
-            logger.debug('Pooch download completed: %s', result_path)
+            logger.debug('Download success: %s', result_path)
             return result_path
         except requests.RequestException as e:
-            logger.error('Failed to download ontology: %s', e)
+            logger.error('Download failed: %s', e)
             raise
         except OSError as e:
-            logger.error('Failed to save downloaded ontology: %s', e)
+            logger.error('Download failed: %s', e)
             raise
 
     def _validate_download_parameters(
@@ -187,7 +193,7 @@ def _perform_download(self, url_ontology: str, filename: str) -> Path:
             progressbar=True,
         )
         result_path = Path(resource_path)
-        logger.debug('Successfully downloaded ontology to %s', result_path)
+        logger.debug('Download success: %s', result_path)
         return result_path
 
     def fetch_from_catalog(
@@ -211,7 +217,7 @@ def fetch_from_catalog(
         if not resources:
             raise ValueError('Resources list for batch download is empty.')
 
-        logger.debug('Fetching %s resources from catalog', len(resources))
+        logger.debug('Catalog batch download: %s items', len(resources))
         results = {}
         for resource in resources:
             name_id, format_type = self._extract_resource_info(resource)
@@ -316,16 +322,14 @@ def fetch_from_url(self, url_ontology: str, filename: str | None) -> Path:
         self._validate_download_parameters(url_ontology, filename)
 
         dest = self._cache_dir / filename
-        logger.info(
-            'DownloadManager download started: %s -> %s', url_ontology, dest
-        )
+        logger.info('Download start: %s -> %s', url_ontology, dest)
         result_path = self._manager.download(url_ontology, dest=str(dest))
         if not result_path:
             raise OSError('Download manager did not return a file path.')
 
         result = Path(result_path)
         self._resources_paths[dest.stem] = result
-        logger.debug('DownloadManager download completed: %s', result)
+        logger.debug('Download success: %s', result)
         return result
 
     def fetch_from_catalog(
@@ -349,7 +353,7 @@ def fetch_from_catalog(
         if not resources:
             raise ValueError('Resources list for batch download is empty.')
 
-        logger.debug('Fetching %s resources from catalog', len(resources))
+        logger.debug('Catalog batch download: %s items', len(resources))
         results = {}
         for resource in resources:
             name_id, format_type = self._extract_resource_info(resource)

ontograph/loader.py

@@ -413,10 +413,9 @@ def _download_ontology(
         logger.debug(f'Created default downloader: {type(downloader).__name__}')
 
         logger.info(
-            'Downloading ontology %s.%s using %s (catalog)',
+            'Ontology download start: %s.%s (catalog)',
             name_id,
             format,
-            type(downloader).__name__,
         )
         resources = [{'name_id': name_id, 'format': format}]
         try:
@@ -520,11 +519,7 @@ def load_from_url(
             downloader = get_default_downloader(cache_dir=self.cache_dir)
         logger.debug(f'Created default downloader: {type(downloader).__name__}')
 
-        logger.info(
-            'Downloading ontology from URL using %s: %s',
-            type(downloader).__name__,
-            url_ontology,
-        )
+        logger.info('Ontology download start: %s (url)', url_ontology)
         file_path: Path = downloader.fetch_from_url(
             url_ontology=url_ontology,
             filename=filename,

ontograph/models.py

@@ -70,12 +70,8 @@ def _download_registry(
         if downloader is None:
             downloader = get_default_downloader(cache_dir=self.cache_dir)
 
-        logger.info(
-            'Downloading OBO Foundry registry using %s: %s',
-            type(downloader).__name__,
-            OBO_FOUNDRY_REGISTRY_URL,
-        )
-        logger.debug('Catalog file path: %s', catalog_path)
+        logger.info('Catalog download start: %s', OBO_FOUNDRY_REGISTRY_URL)
+        logger.debug('Catalog download target: %s', catalog_path)
         downloader.fetch_from_url(
             url_ontology=OBO_FOUNDRY_REGISTRY_URL,
             filename=NAME_OBO_FOUNDRY_CATALOG,