test: clean organization in tests and update the schema

Author: ecarrenolozano

tests/unit/test_logger.py

@@ -1,9 +1,17 @@
 """
+Unit tests for logger utilities.
+
 Unit test organization:
-    - Nominal Case Tests
-    - Negative Case Tests
-    - Edge Case Tests
-    - Regression Unit Tests
+        - Nominal Case Tests: Test the nominal case where the function is expected
+            to work correctly with typical input values.
+        - Negative Case Tests: Test cases that involve invalid input values or
+            scenarios where the function should handle errors gracefully.
+        - Edge Case Tests: Test cases that involve boundary conditions or unusual
+            input values that may not be common but should still be handled correctly
+            by the function.
+        - Regression Unit Tests: Test cases that ensure that previously fixed bugs
+            do not reoccur and that existing functionality remains intact after
+            changes to the codebase.
 """
 
 from __future__ import annotations
@@ -29,8 +37,9 @@
     list_loggers,
 )
 
+
 # =============================================================================
-# ==== Fixtures
+# ==== Fixtures and Setup
 # =============================================================================
 
 @pytest.fixture(autouse=True)
@@ -128,8 +137,9 @@ def fallback_logging_config_file(tmp_path, fallback_logging_config):
     return cfg
 
 
+
 # =============================================================================
-# ==== Initialize Logging Tests
+# ==== Class Test Cases
 # =============================================================================
 
 class TestInitializeLogging:
@@ -176,10 +186,6 @@ def test_no_duplicate_handlers(self, minimal_logging_config):
         assert before == after
 
 
-# =============================================================================
-# ==== Get Logger Tests
-# =============================================================================
-
 class TestGetLogger:
     """Tests for get_logger validation and behavior."""
 
@@ -244,10 +250,6 @@ def test_logger_propagates_but_root_has_no_handlers(self):
             get_logger("test")
 
 
-# =============================================================================
-# ==== Configuration Behavior Tests
-# =============================================================================
-
 class TestLoggingConfiguration:
     """Tests for configuration transformations and filesystem effects."""
 
@@ -270,10 +272,6 @@ def test_timestamped_filename(self, tmp_path, minimal_logging_config):
         assert len(files) > 0
 
 
-# =============================================================================
-# ==== Fallback Behavior Tests
-# =============================================================================
-
 class TestFallbackBehavior:
     """Tests for fallback handler behavior."""
 
@@ -336,11 +334,6 @@ def test_no_fallback_if_root_has_handlers(self, tmp_path, monkeypatch):
         handler_types = {type(h).__name__ for h in root.handlers}
         assert handler_types == {"StreamHandler"}
 
-
-# =============================================================================
-# ==== Logger Introspection Tests
-# =============================================================================
-
 class TestLoggerIntrospection:
     """Tests for logger discovery utilities."""
 
@@ -350,10 +343,6 @@ def test_list_loggers_contains_registered(self, initialized_logging):
         assert "test_logger" in names
 
 
-# =============================================================================
-# ==== Internal Coverage Tests
-# =============================================================================
-
 class TestLoggerInternals:
     """Tests targeting uncovered internal branches."""
 
@@ -437,7 +426,7 @@ def test_initialize_logging_file_already_initialized(self, tmp_path, minimal_log
 
 
 # =============================================================================
-# ==== Additional Internal/Utility Tests (Missing Coverage)
+# ==== Function Test Cases
 # =============================================================================
 
 def test_logfilemanager_create_log_directories(tmp_path):

tests/unit/test_schema.py

@@ -2,19 +2,16 @@
 Unit tests for schema validation utilities.
 
 Unit test organization:
-    - Nominal Case Tests: Test the nominal case where the function is expected
-      to work correctly with typical input values.
-
-    - Negative Case Tests: Test cases that involve invalid input values or
-      scenarios where the function should handle errors gracefully.
-
-    - Edge Case Tests: Test cases that involve boundary conditions or unusual
-      input values that may not be common but should still be handled correctly
-      by the function.
-
-    - Regression Unit Tests: Test cases that ensure that previously fixed bugs
-      do not reoccur and that existing functionality remains intact after
-      changes to the codebase.
+        - Nominal Case Tests: Test the nominal case where the function is expected
+            to work correctly with typical input values.
+        - Negative Case Tests: Test cases that involve invalid input values or
+            scenarios where the function should handle errors gracefully.
+        - Edge Case Tests: Test cases that involve boundary conditions or unusual
+            input values that may not be common but should still be handled correctly
+            by the function.
+        - Regression Unit Tests: Test cases that ensure that previously fixed bugs
+            do not reoccur and that existing functionality remains intact after
+            changes to the codebase.
 """
 
 from __future__ import annotations
@@ -27,10 +24,7 @@
 from pydantic import ValidationError
 
 # Local imports
-from pkg_infra.schema import (
-    validate_settings, 
-    _format_validation_errors,
-)
+from pkg_infra.schema import validate_settings
 
 # =============================================================================
 # ==== Fixtures and Setup
@@ -70,6 +64,7 @@ def valid_config_dict() -> dict[str, object]:
             'formatters': {},
             'handlers': {},
             'loggers': {},
+            'filters': {},
             'root': {
                 'level': 'WARNING',
                 'handlers': [],
@@ -154,65 +149,4 @@ def test_validation_error_preserves_offending_field_name(
         assert 'my_custon_field_app' in str(exc_info.value)
 
 
-class TestFormatValidationErrors:
-    """Test cases for _format_validation_errors."""
-
-    # ---- Nominal Case Tests
-    def test_single_error_is_formatted_correctly(
-        self,
-        valid_config_dict: dict[str, object],
-    ) -> None:
-        """Test that a single validation error is rendered compactly."""
-        invalid_config = deepcopy(valid_config_dict)
-        invalid_config['my_custon_field_app'] = {
-            'name': 'demo',
-            'environment': 'dev',
-            'logger': 'default',
-        }
-
-        with pytest.raises(ValidationError) as exc_info:
-            validate_settings(invalid_config)
-
-        formatted_errors = _format_validation_errors(exc_info.value)
-
-        assert formatted_errors == [
-            'my_custon_field_app: Extra inputs are not permitted'
-        ]
-
-    # ---- Edge Case Tests
-    def test_nested_error_locations_are_formatted_with_dots(
-        self,
-        valid_config_dict: dict[str, object],
-    ) -> None:
-        """Test that nested validation locations are joined with dots."""
-        invalid_config = deepcopy(valid_config_dict)
-        invalid_config['app']['logger'] = 42
-
-        with pytest.raises(ValidationError) as exc_info:
-            validate_settings(invalid_config)
-
-        formatted_errors = _format_validation_errors(exc_info.value)
-
-        assert formatted_errors == ['app.logger: Input should be a valid string']
-
-    # ---- Regression Unit Tests
-    def test_formatted_errors_keep_exact_field_path_text(
-        self,
-        valid_config_dict: dict[str, object],
-    ) -> None:
-        """Test that formatted errors keep exact offending field names."""
-        invalid_config = deepcopy(valid_config_dict)
-        invalid_config['my_custon_field_app'] = {
-            'name': 'demo',
-            'environment': 'dev',
-            'logger': 'default',
-        }
-
-        with pytest.raises(ValidationError) as exc_info:
-            validate_settings(invalid_config)
-
-        formatted_errors = _format_validation_errors(exc_info.value)
 
-        assert 'my_custon_field_app: Extra inputs are not permitted' in (
-            formatted_errors
-        )

tests/unit/test_session.py

@@ -1,19 +1,17 @@
 """
-Unit test organization:
-    - Nominal Case Tests: Test the nominal case where the function is expected
-      to work correctly with typical input values.
-
-    - Negative Case Tests: Test cases that involve invalid input values or
-      scenarios where the function should handle errors gracefully.
-
-    - Edge Case Tests: Test cases that involve boundary conditions or unusual
-      input values that may not be common but should still be handled correctly
-      by the function.
-
-    - Regression Unit Tests: Test cases that ensure that previously fixed bugs
-      do not reoccur and that existing functionality remains intact after
-      changes to the codebase.
+Unit tests for session management utilities.
 
+Unit test organization:
+        - Nominal Case Tests: Test the nominal case where the function is expected
+            to work correctly with typical input values.
+        - Negative Case Tests: Test cases that involve invalid input values or
+            scenarios where the function should handle errors gracefully.
+        - Edge Case Tests: Test cases that involve boundary conditions or unusual
+            input values that may not be common but should still be handled correctly
+            by the function.
+        - Regression Unit Tests: Test cases that ensure that previously fixed bugs
+            do not reoccur and that existing functionality remains intact after
+            changes to the codebase.
 """
 
 # Standard imports