Skip to content

The complexes query reports stripped references incorrectly #214

Open
@pokedthefrog

Description

@pokedthefrog

When calling omnipath.requests.Complexes.complex_genes(), the references column always reports stripped references which, in turn, results in the references_stripped column containing rubbish data. This seems to be a problem with the web service (see here) and also exists in pypath.

I am not sure if always reporting back stripped references for complexes is an intentional choice. Regardless, it is the following snippet that seems to break the references_stripped column:

https://github.com/saezlab/omnipath/blob/f48c3bb37c91ebf3cfd8261236c7770bcdab6cf2/omnipath/_core/requests/_utils.py#L151-L157

Changing the regex to something that ensures that the label does indeed exist seems to provide a temporary fix: (?=.*[a-zA-Z])[-\w]*:?(\d+). I understand, though, that this is a minor issue and making this change may unintentionally break something else.

Thanks a lot for the amazing package and your help! 😊

Metadata

Metadata

Assignees

Labels

bugProblem in the code

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions