MacOS integration!

[Friendly-Aid]

I made MacOS integration for AutoRewarder. I have not been able to test it a lot for bugs or errors, but it seems to work well.

Link to my fork github.com/Friendly-Aid/AutoRewarder.

(Note for safarsin): I would love to collaborate with you on this, increasing compatibility with different operating systems, and I have a few ideas I would love to share.

[safarsin]

Hey, @Friendly-Aid. Thanks, I appreciate it. Bringing macOS support is a cool addition.

To be completely honest with you: I don't own a Mac. Because of this, I unfortunately just can't test the code, debug issues, or maintain the macOS side of the project.

However, I definitely don't want your work to go to waste. As a compromise, I'd be happy to create a dedicated macos branch for this integration. Since I can't test it, I'd need to rely on you to be the primary maintainer for the macOS version and handle the specific issues for that OS.

Let me know how you feel about this, and I'd love to hear the other ideas you wanted to share.

[Friendly-Aid]

That sounds good to me! Also I have looked into integration with other browsers and it seems like something I could do, I have already been able to set up integration with chrome which seems to work except for the first time getting the rewards points data. I would love to set up integration for whatever browsers you would like integration for, but I would like to know exactly what browsers you would want me to integrate; if you would like me to pursue browser integration further I would love to know and make a new discussion for it.

[safarsin]

I love the enthusiasm. But let's take it one step at a time. First, let's finish the Mac integration, which is exactly what this thread was created for.

Everything in its own time! Once we get the current Mac stuff, then the min-max logic finalized and merged, please feel free to open a new discussion for the other ideas.

[Friendly-Aid]

I already finished updating the MacOS integration to V4.0 but I can't make A PR because the MacOS branch seems to not exist anymore.

[safarsin]

I must've accidentally deleted it during the recent cleanup for v4.0. I've just recreated the macOS-integration branch. You should be able to push and open your PR now.

[Friendly-Aid]

I made a PR for the macOS integration branch, and a PR to fix a delay and error message when closing the tabs after clicking on news images or videos.

[argtime]

I tested. Works amazing, including the mobile searches. Thank you! My only issues were the clickable link and appnope not being in the requirements, so basically nothing.

[Friendly-Aid]

Those problems should be fixed now. Thanks for the feedback!

[JeromeM]

I will test it on my mac this afternoon.

Is it possible to have two separate PR ?

• One with the MacOS update
• One with the tabs

We also need to take a look at how we can compile it with a proper installer for Macos..

[safarsin]

His PR #66 is already for the tabs.

And it'd be awesome if you could take control of the macOS integration.

[JeromeM]

Sure, I will do it !

[Friendly-Aid]

Hi, I would love to know how JeromeM would end up taking over the MacOS integration and what all he would end up doing. That way I know where to best spend my resources if I want to contribute.

[JeromeM]

I will do all the reviews / tests of your work.
At the same time, I will take a look at what tools we can use to automatize the installation on MacOS (for windows it's Innosetup).

[Friendly-Aid]

Working on updating integration to V4.0; just doing some basic testing before hand to make sure none of the code conflicts, then I will send a PR.

[Friendly-Aid]

I finished with testing my MacOS integration for V4.0 and when I went to make a PR there was no MacOS branch. Was it removed on purpose?