Skip to content

Fix typing for EIP1271 hashing #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Uxio0 merged 1 commit into from
Jun 9, 2025
Merged

Fix typing for EIP1271 hashing #1717

Uxio0 merged 1 commit into from
Jun 9, 2025
+5 −5

Conversation

@Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Jun 9, 2025

No description provided.

@Uxio0 Uxio0 requested a review from a team as a code owner June 9, 2025 09:23
@coveralls
Copy link

coveralls commented Jun 9, 2025

Pull Request Test Coverage Report for Build 15536533327

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 93.98%
Files with Coverage Reduction New Missed Lines %
safe_eth/eth/clients/etherscan_client_v2.py 1 90.63%
safe_eth/eth/tests/clients/test_etherscan_client_v2.py 1 88.89%
Totals Coverage Status
Change from base Build 15533978760: -0.009%
Covered Lines: 9569
Relevant Lines: 10182
💛 - Coveralls

@Uxio0 Uxio0 merged commit 294ac54 into main Jun 9, 2025
7 checks passed
@Uxio0 Uxio0 deleted the fix-typing branch June 9, 2025 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Uxio0 @coveralls @falvaradorodriguez