Validate token registration semantic version

Author: Uxio0

requirements.txt

@@ -21,6 +21,7 @@ firebase-admin==4.3.0
 gnosis-py==2.5.6
 gunicorn[gevent]==20.0.4
 hexbytes==0.2.1
+packaging>=19.2
 psycopg2-binary==2.8.5
 redis==3.5.3
 requests==2.24.0

safe_transaction_service/notifications/serializers.py

@@ -3,6 +3,7 @@
 
 from django.db import IntegrityError
 
+from packaging import version as semantic_version
 from rest_framework import serializers
 
 from gnosis.eth.django.serializers import EthereumAddressField
@@ -23,9 +24,16 @@ class FirebaseDeviceSerializer(serializers.Serializer):
 
     def validate_safes(self, safes: Sequence[str]):
         if SafeContract.objects.filter(address__in=safes).count() != len(safes):
-            raise serializers.ValidationError("At least one Safe provided was not found")
+            raise serializers.ValidationError('At least one Safe provided was not found')
         return safes
 
+    def validate_version(self, value: str):
+        try:
+            semantic_version.Version(value)
+        except semantic_version.InvalidVersion:
+            raise serializers.ValidationError('Semantic version was expected')
+        return value
+
     def save(self, **kwargs):
         try:
             firebase_device, _ = FirebaseDevice.objects.update_or_create(

safe_transaction_service/notifications/tests/test_views.py

@@ -67,11 +67,20 @@ def test_notifications_devices_create_view(self):
         self.assertEqual(FirebaseDevice.objects.first().safes.count(), 2)
 
         # Use not valid deviceType
+        previous_device_type = data['deviceType']
         data['deviceType'] = 'RANGER-MORPHER'
         response = self.client.post(reverse('v1:notifications-devices'), format='json', data=data)
         self.assertIn('is not a valid choice', response.content.decode())
         self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
         self.assertEqual(safe_contract.firebase_devices.count(), 1)
+        data['deviceType'] = previous_device_type
+
+        # Use not valid version
+        data['version'] = 'Megazord'
+        response = self.client.post(reverse('v1:notifications-devices'), format='json', data=data)
+        self.assertIn('Semantic version was expected', response.content.decode())
+        self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST)
+        self.assertEqual(safe_contract.firebase_devices.count(), 1)
 
     def test_notifications_devices_delete_view(self):
         safe_contract = SafeContractFactory()