Skip to content

Commit 6056eff

Browse files
committed
Force limit of v1 Safes for owner/modules endpoint
- v2 paginated version is available already. - This endpoint can take a long time and use a lot of resources for owners/modules with a lot of Safes. - Instead of deprecating it, a sane limit will only affect a small percentage of users, but will prevent issues on the service.
1 parent 5537dc9 commit 6056eff

File tree

1 file changed

+6
-2
lines changed
  • safe_transaction_service/history

1 file changed

+6
-2
lines changed

safe_transaction_service/history/views.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1162,7 +1162,9 @@ def get(self, request, address, *args, **kwargs):
11621162
},
11631163
)
11641164

1165-
safes_for_module = SafeLastStatus.objects.addresses_for_module(address)
1165+
safes_for_module = SafeLastStatus.objects.addresses_for_module(address)[
1166+
: pagination.DefaultPagination.max_limit
1167+
]
11661168
serializer = self.get_serializer(data={"safes": safes_for_module})
11671169
assert serializer.is_valid()
11681170
return Response(status=status.HTTP_200_OK, data=serializer.data)
@@ -1197,7 +1199,9 @@ def get(self, request, address, *args, **kwargs):
11971199
},
11981200
)
11991201

1200-
safes_for_owner = SafeLastStatus.objects.addresses_for_owner(address)
1202+
safes_for_owner = SafeLastStatus.objects.addresses_for_owner(address)[
1203+
: pagination.DefaultPagination.max_limit
1204+
]
12011205
serializer = self.get_serializer(data={"safes": safes_for_owner})
12021206
assert serializer.is_valid()
12031207
return Response(status=status.HTTP_200_OK, data=serializer.data)

0 commit comments

Comments
 (0)